From commits-return-80546-archive-asf-public=cust-asf.ponee.io@maven.apache.org Mon May 20 17:04:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EF1D18076D for ; Mon, 20 May 2019 19:04:04 +0200 (CEST) Received: (qmail 78891 invoked by uid 500); 20 May 2019 17:04:03 -0000 Mailing-List: contact commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list commits@maven.apache.org Received: (qmail 78858 invoked by uid 99); 20 May 2019 17:04:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 17:04:03 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 303DD85D01; Mon, 20 May 2019 17:04:03 +0000 (UTC) Date: Mon, 20 May 2019 17:04:04 +0000 To: "commits@maven.apache.org" Subject: [maven-pmd-plugin] 01/01: [MPMD-288] - NullPointerException fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: adangel@apache.org In-Reply-To: <155837184312.27139.990942705168187425@gitbox.apache.org> References: <155837184312.27139.990942705168187425@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: maven-pmd-plugin X-Git-Refname: refs/heads/MPMD-288 X-Git-Reftype: branch X-Git-Rev: 6b40dc747cd076d98c50fd7091a01b56c9651eea X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20190520170403.303DD85D01@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. adangel pushed a commit to branch MPMD-288 in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git commit 6b40dc747cd076d98c50fd7091a01b56c9651eea Author: Wil AuthorDate: Fri May 10 16:57:48 2019 +0200 [MPMD-288] - NullPointerException fix Closes #11 Fixed NullPointerException this line throws NPE when file.list is null https://docs.oracle.com/javase/8/docs/api/java/io/File.html#list-- For me this occurs on jar files like `~/.m2/repository/org/apache/logging/log4j/log4j-api/2.11.1/log4j-api-2.11.1.jar` Contributed by: Wil Carmon --- src/main/java/org/apache/maven/plugins/pmd/PmdReport.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java index f88c89a..b3c5135 100644 --- a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java +++ b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java @@ -769,7 +769,9 @@ public class PmdReport for ( String path : projectCompileClasspath ) { File pathFile = new File( path ); - if ( !pathFile.exists() || pathFile.list().length == 0 ) + String[] children = pathFile.list(); + + if ( !pathFile.exists() || ( children != null && children.length == 0 ) ) { getLog().warn( "The project " + localProject.getArtifactId() + " does not seem to be compiled. PMD results might be inaccurate." );