Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CE15200D5E for ; Fri, 8 Dec 2017 19:14:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B7D0160C1F; Fri, 8 Dec 2017 18:14:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 84674160C20 for ; Fri, 8 Dec 2017 19:14:47 +0100 (CET) Received: (qmail 5918 invoked by uid 500); 8 Dec 2017 18:14:44 -0000 Mailing-List: contact commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list commits@maven.apache.org Received: (qmail 5420 invoked by uid 99); 8 Dec 2017 18:14:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 18:14:43 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id C209B857E3; Fri, 8 Dec 2017 18:14:42 +0000 (UTC) Date: Fri, 08 Dec 2017 18:15:04 +0000 To: "commits@maven.apache.org" Subject: =?utf-8?q?=5Bmaven-mapping=5D_23/42=3A_=5BMSHARED-452=5D=C2=A0Re?= =?utf-8?q?moved_calling_to_accessor?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: hboutemy@apache.org In-Reply-To: <151275688188.13144.3847079459477753515@gitbox.apache.org> References: <151275688188.13144.3847079459477753515@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: maven-mapping X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: d1f9a8965b1ef161321d3c2ca459cba200fa3674 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20171208181442.C209B857E3@gitbox.apache.org> archived-at: Fri, 08 Dec 2017 18:14:48 -0000 This is an automated email from the ASF dual-hosted git repository. hboutemy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-mapping.git commit d1f9a8965b1ef161321d3c2ca459cba200fa3674 Author: Karl Heinz Marbaise AuthorDate: Sat Oct 31 14:09:18 2015 +0000 [MSHARED-452] Removed calling to accessor git-svn-id: https://svn.apache.org/repos/asf/maven/shared/trunk@1711636 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/java/org/apache/maven/shared/mapping/MappingUtils.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java b/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java index 7667838..6668527 100644 --- a/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java +++ b/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java @@ -65,10 +65,6 @@ public class MappingUtils { String value = expression; - // FIXME: This is BAD! Accessors SHOULD NOT change the behavior of the object. - // [dennisl; 2013-07-30] This was fixed in Maven 2.0.8 - artifact.isSnapshot(); - RegexBasedInterpolator interpolator = new RegexBasedInterpolator( "\\@\\{(", ")?([^}]+)\\}@" ); interpolator.addValueSource( new ObjectBasedValueSource( artifact ) ); interpolator.addValueSource( new ObjectBasedValueSource( artifact.getArtifactHandler() ) ); -- To stop receiving notification emails like this one, please contact "commits@maven.apache.org" .