maven-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From schu...@apache.org
Subject [1/2] maven-integration-testing git commit: [MNG-6173] getAllProjects() should return all projects
Date Sat, 04 Mar 2017 21:38:26 GMT
Repository: maven-integration-testing
Updated Branches:
  refs/heads/MNG-6173 [created] 6863bf5a9


[MNG-6173] getAllProjects() should return all projects

Adds a test for checking that MavenSession.getAllProjects() returns the full
list of projects in the reactor even when only some of them are selected
for being built.


Project: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/ce2d0fe5
Tree: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/tree/ce2d0fe5
Diff: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/diff/ce2d0fe5

Branch: refs/heads/MNG-6173
Commit: ce2d0fe5df2bd714af83dac65398f806c6ba4a3e
Parents: c4cd8cf
Author: Christoph Böhme <christoph@b3e.net>
Authored: Fri Mar 3 22:07:17 2017 +0100
Committer: Christian Schulte <schulte@apache.org>
Committed: Sat Mar 4 22:37:47 2017 +0100

----------------------------------------------------------------------
 .../apache/maven/it/IntegrationTestSuite.java   |  1 +
 ...venITmng6173GetAllProjectsInReactorTest.java | 84 ++++++++++++++++++++
 .../module-1/pom.xml                            | 58 ++++++++++++++
 .../module-2/pom.xml                            | 30 +++++++
 .../pom.xml                                     | 35 ++++++++
 5 files changed, 208 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/ce2d0fe5/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
index f6c6114..b019f70 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
@@ -106,6 +106,7 @@ public class IntegrationTestSuite
         // -------------------------------------------------------------------------------------------------------------
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
 
+        suite.addTestSuite( MavenITmng6173GetAllProjectsInReactorTest.class );
         suite.addTestSuite( MavenITmng5958LifecyclePhaseBinaryCompat.class );
         suite.addTestSuite( MavenITmng5898BuildMultimoduleWithEARFailsToResolveWARTest.class
);
         suite.addTestSuite( MavenITmng5889CoreExtensionsTest.class );

http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/ce2d0fe5/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6173GetAllProjectsInReactorTest.java
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6173GetAllProjectsInReactorTest.java
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6173GetAllProjectsInReactorTest.java
new file mode 100644
index 0000000..3bff30a
--- /dev/null
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6173GetAllProjectsInReactorTest.java
@@ -0,0 +1,84 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.*;
+
+/**
+ * Test case for <a href="https://issues.apache.org/jira/browse/MNG-6173">MNG-6173</a>.
+ */
+public class MavenITmng6173GetAllProjectsInReactorTest
+        extends AbstractMavenIntegrationTestCase
+{
+
+    public MavenITmng6173GetAllProjectsInReactorTest()
+    {
+        super( "[3.2.1,3.3.1),[3.5.0-alpha-1,)" );
+    }
+
+    /**
+     * Verifies that {@code MavenSession#getAllProjects()} returns all projects in the reactor
+     * not only they ones being built.
+     */
+    public void testitShouldReturnAllProjectsInReactor()
+            throws Exception
+    {
+
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-6173-get-all-projects-in-reactor"
);
+
+        Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+        verifier.setAutoclean( false );
+        verifier.deleteDirectory( "target" );
+        verifier.deleteDirectory( "module-1/target" );
+        verifier.deleteDirectory( "module-2/target" );
+        verifier.addCliOption( "-pl" );
+        verifier.addCliOption( "module-1" );
+        verifier.executeGoal( "validate" );
+        verifier.verifyErrorFreeLog();
+        verifier.resetStreams();
+
+        Properties properties = verifier.loadProperties( "module-1/target/session.properties"
);
+        assertEquals( "3", properties.getProperty( "session.allProjects.size" ) );
+        assertEquals( Arrays.asList( new String[]{ "base-project", "module-1", "module-2"
} ),
+                getProjects( properties ) );
+    }
+
+    private List<String> getProjects(Properties properties )
+    {
+        List<String> projects = new ArrayList<>();
+
+        for ( Object o : properties.keySet() )
+        {
+            String key = o.toString();
+            if ( key.startsWith( "session.allProjects." ) && !key.endsWith( ".size"
) )
+            {
+                projects.add( properties.getProperty( key ) );
+            }
+        }
+
+        Collections.sort( projects );
+
+        return projects;
+    }
+
+}

http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/ce2d0fe5/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-1/pom.xml
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-1/pom.xml
b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-1/pom.xml
new file mode 100644
index 0000000..1379931
--- /dev/null
+++ b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-1/pom.xml
@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>mng-6173-get-all-projects-in-reactor</groupId>
+  <artifactId>module-1</artifactId>
+  <version>0.1</version>
+  <packaging>pom</packaging>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.plugins</groupId>
+        <artifactId>maven-it-plugin-expression</artifactId>
+        <version>2.1-SNAPSHOT</version>
+        <configuration>
+          <outputFile>target/session.properties</outputFile>
+          <expressions>
+            <expression>session/allProjects/size</expression>
+            <expression>session/allProjects/0/artifactId</expression>
+            <expression>session/allProjects/1/artifactId</expression>
+            <expression>session/allProjects/2/artifactId</expression>
+          </expressions>
+        </configuration>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>validate</phase>
+            <goals>
+              <goal>eval</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/ce2d0fe5/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-2/pom.xml
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-2/pom.xml
b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-2/pom.xml
new file mode 100644
index 0000000..c807d40
--- /dev/null
+++ b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/module-2/pom.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>mng-6173-get-all-projects-in-reactor</groupId>
+  <artifactId>module-2</artifactId>
+  <version>0.1</version>
+  <packaging>pom</packaging>
+</project>

http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/ce2d0fe5/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/pom.xml
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/pom.xml
b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/pom.xml
new file mode 100644
index 0000000..91d5b06
--- /dev/null
+++ b/core-it-suite/src/test/resources/mng-6173-get-all-projects-in-reactor/pom.xml
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>mng-6173-get-all-projects-in-reactor</groupId>
+  <artifactId>base-project</artifactId>
+  <version>0.1</version>
+  <packaging>pom</packaging>
+
+  <modules>
+    <module>module-1</module>
+    <module>module-2</module>
+  </modules>
+</project>


Mime
View raw message