Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0296D200C24 for ; Wed, 8 Feb 2017 21:56:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0126D160B49; Wed, 8 Feb 2017 20:56:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4AC70160B5A for ; Wed, 8 Feb 2017 21:56:02 +0100 (CET) Received: (qmail 43616 invoked by uid 500); 8 Feb 2017 20:56:01 -0000 Mailing-List: contact commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list commits@maven.apache.org Received: (qmail 43600 invoked by uid 99); 8 Feb 2017 20:56:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 20:56:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 41044DFDD1; Wed, 8 Feb 2017 20:56:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: rfscholte@apache.org To: commits@maven.apache.org Date: Wed, 08 Feb 2017 20:56:01 -0000 Message-Id: <5c360f52a371403fb13d73ad7e30f9a5@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] maven git commit: PluginDescriptor doesn't read since value of parameter archived-at: Wed, 08 Feb 2017 20:56:03 -0000 Repository: maven Updated Branches: refs/heads/MNG-6109 [created] 862e8e4e3 PluginDescriptor doesn't read since value of parameter Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/76b539ec Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/76b539ec Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/76b539ec Branch: refs/heads/MNG-6109 Commit: 76b539ecf2733b2a8564c18581d60176dc0185a3 Parents: 66a0fbe Author: rfscholte Authored: Mon Oct 31 21:05:28 2016 +0100 Committer: rfscholte Committed: Wed Feb 8 21:53:55 2017 +0100 ---------------------------------------------------------------------- .../apache/maven/plugin/descriptor/PluginDescriptorBuilder.java | 2 ++ .../maven/plugin/descriptor/PluginDescriptorBuilderTest.java | 1 + maven-plugin-api/src/test/resources/plugin.xml | 1 + 3 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/maven/blob/76b539ec/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java index 7224554..9508c51 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java @@ -299,6 +299,8 @@ public class PluginDescriptorBuilder parameter.setImplementation( d.getChild( "implementation" ).getValue() ); + parameter.setSince( d.getChild( "since" ).getValue() ); + PlexusConfiguration paramConfig = mojoConfig.getChild( parameter.getName(), false ); if ( paramConfig != null ) { http://git-wip-us.apache.org/repos/asf/maven/blob/76b539ec/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java b/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java index 799e3af..b9f5ab9 100644 --- a/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java +++ b/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java @@ -108,6 +108,7 @@ public class PluginDescriptorBuilderTest assertEquals( "deprecated-parameter", mp.getDeprecated() ); assertEquals( "${jar.finalName}", mp.getExpression() ); assertEquals( "${project.build.finalName}", mp.getDefaultValue() ); + assertEquals( "3.0.0", mp.getSince() ); ComponentRequirement cr = md.getRequirements().get( 0 ); http://git-wip-us.apache.org/repos/asf/maven/blob/76b539ec/maven-plugin-api/src/test/resources/plugin.xml ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/test/resources/plugin.xml b/maven-plugin-api/src/test/resources/plugin.xml index 6b97211..add46dc 100644 --- a/maven-plugin-api/src/test/resources/plugin.xml +++ b/maven-plugin-api/src/test/resources/plugin.xml @@ -60,6 +60,7 @@ under the License. true parameter-description deprecated-parameter + 3.0.0