maven-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From micha...@apache.org
Subject svn commit: r1777736 - /maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
Date Fri, 06 Jan 2017 23:54:39 GMT
Author: michaelo
Date: Fri Jan  6 23:54:39 2017
New Revision: 1777736

URL: http://svn.apache.org/viewvc?rev=1777736&view=rev
Log:
Drop some exception

The API does not clearly describe wether this can be null or not. Even if, a NPE would be
appropriate. At at the end, an null value will fail with an NPE.

Modified:
    maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java

Modified: maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java?rev=1777736&r1=1777735&r2=1777736&view=diff
==============================================================================
--- maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
(original)
+++ maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
Fri Jan  6 23:54:39 2017
@@ -237,11 +237,6 @@ public abstract class AbstractMavenRepor
     public void generate( Sink sink, SinkFactory sinkFactory, Locale locale )
         throws MavenReportException
     {
-        if ( sink == null )
-        {
-            throw new MavenReportException( "You must specify a sink." );
-        }
-
         if ( !canGenerateReport() )
         {
             getLog().info( "This report cannot be generated as part of the current build.
"



Mime
View raw message