maven-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject svn commit: r1590562 - in /maven/shared/trunk/maven-dependency-analyzer/src: main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
Date Mon, 28 Apr 2014 06:44:35 GMT
Author: olamy
Date: Mon Apr 28 06:44:35 2014
New Revision: 1590562

URL: http://svn.apache.org/r1590562
Log:
not use anymore the deprecated method

Modified:
    maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java
    maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java

Modified: maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java?rev=1590562&r1=1590561&r2=1590562&view=diff
==============================================================================
--- maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java
(original)
+++ maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java
Mon Apr 28 06:44:35 2014
@@ -91,19 +91,6 @@ public class DefaultMethodVisitor
          */
     }
 
-    // TODO remove
-    public void visitMethodInsn( final int opcode, final String owner, final String name,
final String desc )
-    {
-        resultCollector.addName( owner );
-        /*
-         * NOTE: Merely invoking a method does not impose a direct dependency on its return
type nor its parameter
-         * types. For example, the code line <code>bean.method(null);</code>
only depends on the owner type of the
-         * method. A direct dependency is only introduced when the code explicitly references
the method's types by
-         * means of a variable declaration or a type check/cast. Those cases are handled
by other visitor callbacks.
-         */
-    }
-
-    // for java 8 and default method in interfaces
     @Override
     public void visitMethodInsn( int opcode, String owner, String name, String desc, boolean
itf )
     {

Modified: maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java?rev=1590562&r1=1590561&r2=1590562&view=diff
==============================================================================
--- maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
(original)
+++ maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
Mon Apr 28 06:44:35 2014
@@ -460,70 +460,70 @@ public class DependencyVisitorTest
 
     public void testVisitMethodInsn()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()V", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithPrimitiveArgument()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(I)V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(I)V", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithPrimitiveArrayArgument()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "([I)V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "([I)V", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithObjectArgument()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(Lx/y/z;)V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(Lx/y/z;)V", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithObjectArguments()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(Lp/q/r;Lx/y/z;)V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "(Lp/q/r;Lx/y/z;)V", false
);
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithObjectArrayArgument()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "([Lx/y/z;)V" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "([Lx/y/z;)V", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithPrimitiveReturnType()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()I" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()I", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithPrimitiveArrayReturnType()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()[I" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()[I", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithObjectReturnType()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()Lx/y/z;" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()Lx/y/z;", false );
 
         assertClasses( "a.b.c" );
     }
 
     public void testVisitMethodInsnWithObjectArrayReturnType()
     {
-        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()[Lx/y/z;" );
+        mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL, "a/b/c", "x", "()[Lx/y/z;", false );
 
         assertClasses( "a.b.c" );
     }



Mime
View raw message