Return-Path: X-Original-To: apmail-maven-commits-archive@www.apache.org Delivered-To: apmail-maven-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A937BD067 for ; Tue, 18 Dec 2012 03:12:08 +0000 (UTC) Received: (qmail 55941 invoked by uid 500); 18 Dec 2012 03:12:07 -0000 Delivered-To: apmail-maven-commits-archive@maven.apache.org Received: (qmail 55866 invoked by uid 500); 18 Dec 2012 03:12:06 -0000 Mailing-List: contact commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list commits@maven.apache.org Received: (qmail 55840 invoked by uid 99); 18 Dec 2012 03:12:05 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2012 03:12:05 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 6403481E1F4; Tue, 18 Dec 2012 03:12:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: hboutemy@apache.org To: commits@maven.apache.org X-Mailer: ASF-Git Admin Mailer Subject: git commit: is Slf4jConfiguration.setLoggerFile(File) API useful? Message-Id: <20121218031204.6403481E1F4@tyr.zones.apache.org> Date: Tue, 18 Dec 2012 03:12:04 +0000 (UTC) Updated Branches: refs/heads/master 3849bbd46 -> e95060321 is Slf4jConfiguration.setLoggerFile(File) API useful? Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e9506032 Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e9506032 Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e9506032 Branch: refs/heads/master Commit: e950603218f6dcf45fdc8e456b2492a2d05ccb68 Parents: 3849bbd Author: Hervé Boutemy Authored: Tue Dec 18 04:11:57 2012 +0100 Committer: Hervé Boutemy Committed: Tue Dec 18 04:11:57 2012 +0100 ---------------------------------------------------------------------- .../main/java/org/apache/maven/cli/MavenCli.java | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/maven/blob/e9506032/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java index 99ea11b..eb440e4 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java @@ -298,9 +298,9 @@ public class MavenCli } } - // - // All logging is handled by SFL4J - // + /** + * configure logging + */ private void logging( CliRequest cliRequest ) { cliRequest.debug = cliRequest.commandLine.hasOption( CLIManager.DEBUG ); @@ -327,7 +327,8 @@ public class MavenCli { File logFile = new File( cliRequest.commandLine.getOptionValue( CLIManager.LOG_FILE ) ); logFile = resolveFile( logFile, cliRequest.workingDirectory ); - slf4jConfiguration.setLoggerFile( logFile ); + + // redirect stdout and stderr to file try { PrintStream ps = new PrintStream( new FileOutputStream( logFile ) ); @@ -340,6 +341,8 @@ public class MavenCli // Ignore // } + + slf4jConfiguration.setLoggerFile( logFile ); // is it really useful? redirecting stdout/stderr isn't sufficient in all cases? } plexusLoggerManager = new Slf4jLoggerManager();