maven-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvan...@apache.org
Subject svn commit: r757560 - in /maven/components/branches/MNG-2766: maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java
Date Mon, 23 Mar 2009 21:51:37 GMT
Author: jvanzyl
Date: Mon Mar 23 21:51:37 2009
New Revision: 757560

URL: http://svn.apache.org/viewvc?rev=757560&view=rev
Log:
o notes on the sanitizing of the lifecycle executor api

Modified:
    maven/components/branches/MNG-2766/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java
    maven/components/branches/MNG-2766/maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java

Modified: maven/components/branches/MNG-2766/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java
URL: http://svn.apache.org/viewvc/maven/components/branches/MNG-2766/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java?rev=757560&r1=757559&r2=757560&view=diff
==============================================================================
--- maven/components/branches/MNG-2766/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java
(original)
+++ maven/components/branches/MNG-2766/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java
Mon Mar 23 21:51:37 2009
@@ -100,6 +100,13 @@
     // Tests which exercise the lifecycle executor when it is dealing with individual goals.
     // -----------------------------------------------------------------------------------------------
     
+    //TODO: These two tests display a lack of symmetry with respect to the input which is
a free form string and the
+    //      mojo descriptor which comes back. All the free form parsing needs to be done
somewhere else, this is
+    //      really the function of the CLI, and then the pre-processing of that output still
needs to be fed into
+    //      a hinting process which helps flesh out the full specification of the plugin.
The plugin manager should
+    //      only deal in concrete terms -- all version finding mumbo jumbo is a customization
to base functionality
+    //      the plugin manager provides.
+    
     public void testRemoteResourcesPlugin()
         throws Exception
     {
@@ -153,6 +160,8 @@
         containerConfiguration.addComponentDiscoveryListener( new MavenPluginCollector()
);
     }
     
+    //TODO: this is still a narly mess and shows it's still not layered properly. Once these
tests look
+    //      a little better i'll be ready for the next round of refactoring in the plugin
manager.
     protected MavenSession createMavenSession( File pom )
         throws Exception
     {

Modified: maven/components/branches/MNG-2766/maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java
URL: http://svn.apache.org/viewvc/maven/components/branches/MNG-2766/maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java?rev=757560&r1=757559&r2=757560&view=diff
==============================================================================
--- maven/components/branches/MNG-2766/maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java
(original)
+++ maven/components/branches/MNG-2766/maven-project/src/main/java/org/apache/maven/project/ProjectBuilderConfiguration.java
Mon Mar 23 21:51:37 2009
@@ -29,6 +29,7 @@
 
     ProjectBuilderConfiguration setExecutionProperties( Properties executionProperties );
 
+    //TODO: these do not belong here, we can profile things else where
     Date getBuildStartTime();
 
     ProjectBuilderConfiguration setBuildStartTime( Date buildStartTime );    



Mime
View raw message