maven-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bentm...@apache.org
Subject svn commit: r661111 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Date Wed, 28 May 2008 22:00:20 GMT
Author: bentmann
Date: Wed May 28 15:00:19 2008
New Revision: 661111

URL: http://svn.apache.org/viewvc?rev=661111&view=rev
Log:
o Excluded some every day numbers from the MagicNumber check, its false positives are simply
annoying

Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=661111&r1=661110&r2=661111&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
(original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Wed May 28 15:00:19 2008
@@ -150,7 +150,10 @@
         </module>
         <module name="IllegalInstantiation"/>
         <module name="InnerAssignment"/>
-        <module name="MagicNumber"/>
+        <module name="MagicNumber">
+          <!-- some numbers are really not that magic -->
+          <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7,
8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 128, 256, 512, 1024"/>
+        </module>
         <module name="MissingSwitchDefault"/>
         <module name="RedundantThrows"/>
         <module name="SimplifyBooleanExpression"/>



Mime
View raw message