Return-Path: Delivered-To: apmail-maven-commits-archive@www.apache.org Received: (qmail 29375 invoked from network); 15 Jan 2008 04:17:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jan 2008 04:17:59 -0000 Received: (qmail 2583 invoked by uid 500); 15 Jan 2008 04:17:49 -0000 Delivered-To: apmail-maven-commits-archive@maven.apache.org Received: (qmail 2378 invoked by uid 500); 15 Jan 2008 04:17:48 -0000 Mailing-List: contact commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list commits@maven.apache.org Received: (qmail 2365 invoked by uid 99); 15 Jan 2008 04:17:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jan 2008 20:17:48 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jan 2008 04:17:44 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 452AD1A9838; Mon, 14 Jan 2008 20:17:36 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r612012 - /maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java Date: Tue, 15 Jan 2008 04:17:35 -0000 To: commits@maven.apache.org From: vsiveton@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080115041736.452AD1A9838@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: vsiveton Date: Mon Jan 14 20:17:35 2008 New Revision: 612012 URL: http://svn.apache.org/viewvc?rev=612012&view=rev Log: MNG-3273: Point out known pitfalls when developing plugins Submitted by: Benjamin Bentmann Reviewed by: Vincent Siveton o applied Modified: maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java Modified: maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java?rev=612012&r1=612011&r2=612012&view=diff ============================================================================== --- maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java (original) +++ maven/components/branches/maven-2.0.x/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java Mon Jan 14 20:17:35 2008 @@ -159,8 +159,15 @@ } /** - * By default, return a SystemStreamLog logger. - * + * Returns the logger that has been injected into this mojo. If no logger has been setup yet, a SystemStreamLog + * logger will be created and returned. + *

+ * Note: + * The logger returned by this method must not be cached in an instance field during the construction of the mojo. + * This would cause the mojo to use a wrongly configured default logger when being run by Maven. The proper logger + * gets injected by the Plexus container after the mojo has been constructed. Therefore, simply call this + * method directly whenever you need the logger, it is fast enough and needs no caching. + * * @see org.apache.maven.plugin.Mojo#getLog() */ public Log getLog()