From dev-return-19315-archive-asf-public=cust-asf.ponee.io@manifoldcf.apache.org Sun Mar 3 13:08:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 68D4A18067C for ; Sun, 3 Mar 2019 14:08:04 +0100 (CET) Received: (qmail 93741 invoked by uid 500); 3 Mar 2019 13:08:03 -0000 Mailing-List: contact dev-help@manifoldcf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@manifoldcf.apache.org Delivered-To: mailing list dev@manifoldcf.apache.org Received: (qmail 93729 invoked by uid 99); 3 Mar 2019 13:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Mar 2019 13:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 24653C5EDB for ; Sun, 3 Mar 2019 13:08:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.291 X-Spam-Level: X-Spam-Status: No, score=-110.291 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kpTE8l8g_bIZ for ; Sun, 3 Mar 2019 13:08:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 64D275FE0C for ; Sun, 3 Mar 2019 13:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C5ECCE282C for ; Sun, 3 Mar 2019 13:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4D57E25704 for ; Sun, 3 Mar 2019 13:08:00 +0000 (UTC) Date: Sun, 3 Mar 2019 13:08:00 +0000 (UTC) From: "Karl Wright (JIRA)" To: dev@manifoldcf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CONNECTORS-1590) Resources should be closed in a finally block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CONNECTORS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright resolved CONNECTORS-1590. ------------------------------------- Resolution: Won't Fix > Resources should be closed in a finally block > --------------------------------------------- > > Key: CONNECTORS-1590 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1590 > Project: ManifoldCF > Issue Type: Bug > Components: Framework core > Affects Versions: ManifoldCF 2.12 > Reporter: Cihad Guzel > Assignee: Karl Wright > Priority: Major > Fix For: ManifoldCF 2.13 > > > {code:java} > public class DBInterfaceHSQLDB extends Database implements IDBInterface { > ... > try > { > Connection c = DriverManager.getConnection(_localUrl+databaseName,userName,password); > Statement s = c.createStatement(); > s.execute("SHUTDOWN"); > c.close(); > } > catch (Exception e) > { > // Never any exception! > e.printStackTrace(); > } > {code} > Connections that implement the _Closeable_ interface or its super-interface, _AutoCloseable_, needs to be closed after use. That close call must be made in a *finally* block otherwise an exception could keep the call from being made. -- This message was sent by Atlassian JIRA (v7.6.3#76005)