manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julien Massiera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1545) Parentheses in editConfiguration tab labels not supported
Date Wed, 10 Oct 2018 20:10:00 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645486#comment-16645486
] 

Julien Massiera commented on CONNECTORS-1545:
---------------------------------------------

Hi [~kwright@metacarta.com], my explanations were not so clear so let me expose what I noticed
so far :

When the UI is in french, the 'AccessCredentials' is not "clickable" in the web repository
connector configuration. I observed the console log and noticed the following error : 
SyntaxError: "" string literal contains an unescaped line break

So I checked the HTML code of the concerned tab and discovered this : 
<a href="#tab_7" alt="Informations d'accès (Access Credentials) tab" onclick="javascript:SelectTab(&quot;Informations
d" accès="" (access="" credentials)");return="" false;'="">Informations d'accès (Access
Credentials)</a>

 

So as you can see, the onclick function of the tab is clearly wrong because of the tab label
which is re-used somehow here. After reviewing it, I notice that the problem is not caused
by the parentheses but eventually by the apostrophe.

Also, I noticed the same problem for the JDBC connector 

> Parentheses in editConfiguration tab labels not supported
> ---------------------------------------------------------
>
>                 Key: CONNECTORS-1545
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1545
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Web connector
>    Affects Versions: ManifoldCF 2.11
>            Reporter: Julien Massiera
>            Assignee: Karl Wright
>            Priority: Minor
>
> In the editConfiguration view of the web connector, the tab 'AccessCredentials' is not
"clickable" in the french version of the UI.
> It seems to be due to the presence of parentheses in the string "Informations d'accès
(Access Credentials)" as it is used to trigger the javascript function of the tab and so is
misinterpreted
> Need to check if similar cases are present for other connectors 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message