manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1424) Content stream limiter connector
Date Wed, 10 May 2017 11:44:04 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004524#comment-16004524
] 

Karl Wright commented on CONNECTORS-1424:
-----------------------------------------

Looks pretty good.

The only comments I have are:
(1) Please use spaces (2 per indent level) instead of tabs.  It's not a big deal if this can't
be done now but it's very helpful for the future.
(2) The checkLengthIndexable() method seems incorrect.  This method should return activities.checkLengthIndexable(min(length,
sp.lengthCutoff))
(3) The checkMimeTypeIndexable() method should return activities.checkMimeTypeIndexable(mimeType)

Would you like to make these changes, or shall I?




> Content stream limiter connector
> --------------------------------
>
>                 Key: CONNECTORS-1424
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1424
>             Project: ManifoldCF
>          Issue Type: New Feature
>    Affects Versions: ManifoldCF 2.6
>            Reporter: Julien Massiera
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: ManifoldCF 2.8
>
>         Attachments: CONNECTORS-1424.patch
>
>
> It is a transformation connector that truncate the stream content of a doc to the specified
size (bytes)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message