manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1423) New UI makes it impossible to add certificates to connections with certificate stores
Date Fri, 05 May 2017 19:52:04 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998872#comment-15998872
] 

Karl Wright commented on CONNECTORS-1423:
-----------------------------------------

Looking at the javascript code, the problem seems to be the use of postForm():

{code}
function ShpDeleteCertificate(aliasName)
{
  editconnection.shpkeystorealias.value = aliasName;
  editconnection.configop.value = "Delete";
  postForm();
}

function ShpAddCertificate()
{
  if (editconnection.shpcertificate.value == "")
  {
    alert("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('SharePointRepository.ChooseACertificateFile'))");
    editconnection.shpcertificate.focus();
  }
  else
  {
    editconnection.configop.value = "Add";
    postForm();
  }
}
{code}

Now, postForm() is used in quite a number of connector forms, so I'm not sure why it doesn't
work in this circumstance.  [~kishorekumar], any idea?


> New UI makes it impossible to add certificates to connections with certificate stores
> -------------------------------------------------------------------------------------
>
>                 Key: CONNECTORS-1423
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1423
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: LiveLink connector, SharePoint connector, Web connector
>    Affects Versions: ManifoldCF 2.7
>            Reporter: Karl Wright
>            Assignee: Kishore Kumar
>            Priority: Blocker
>
> (1) Create a Sharepoint repository connection
> (2) Click on the Server tab
> (3) Try to add a certificate by finding a valid cert and clicking the "Add" button
> A 500 error is returned.  The exception trace looks like this:
> {code}
> Caused by: java.lang.NullPointerException
>         at java.io.ByteArrayInputStream.<init>(ByteArrayInputStream.java:106)
>         at org.apache.manifoldcf.crawler.connectors.sharepoint.SharePointReposit
> ory.processConfigurationPost(SharePointRepository.java:2359)
>         at org.apache.manifoldcf.core.interfaces.ConnectorFactory.processThisCon
> figurationPost(ConnectorFactory.java:95)
>         at org.apache.manifoldcf.crawler.interfaces.RepositoryConnectorFactory.p
> rocessConfigurationPost(RepositoryConnectorFactory.java:163)
>         at org.apache.jsp.execute_jsp._jspService(execute_jsp.java:313)
>         at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>         at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper
> .java:388)
> {code}
> It looks like the rendering flow is no longer the same, and therefore the certificate
store is not loaded into the local variable that the processConfigurationPost() method is
expecting to find it in.
> The connector code can be rewritten for the connectors where this happens but frankly
this will cause many of the connector UI's out there to break badly.  Is there another way
to address this?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message