Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 396F4200C5A for ; Tue, 18 Apr 2017 20:20:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3822D160BAF; Tue, 18 Apr 2017 18:20:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7CFC7160B87 for ; Tue, 18 Apr 2017 20:20:46 +0200 (CEST) Received: (qmail 75885 invoked by uid 500); 18 Apr 2017 18:20:45 -0000 Mailing-List: contact dev-help@manifoldcf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@manifoldcf.apache.org Delivered-To: mailing list dev@manifoldcf.apache.org Received: (qmail 75752 invoked by uid 99); 18 Apr 2017 18:20:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 18:20:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BE771C1ED1 for ; Tue, 18 Apr 2017 18:20:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cNQz8wUVIh6c for ; Tue, 18 Apr 2017 18:20:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 873BF5FDC4 for ; Tue, 18 Apr 2017 18:20:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD9BFE0875 for ; Tue, 18 Apr 2017 18:20:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C570B21B49 for ; Tue, 18 Apr 2017 18:20:41 +0000 (UTC) Date: Tue, 18 Apr 2017 18:20:41 +0000 (UTC) From: "JC (JIRA)" To: dev@manifoldcf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CONNECTORS-1413) Code smell in equals implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 18 Apr 2017 18:20:47 -0000 JC created CONNECTORS-1413: ------------------------------ Summary: Code smell in equals implementation Key: CONNECTORS-1413 URL: https://issues.apache.org/jira/browse/CONNECTORS-1413 Project: ManifoldCF Issue Type: Bug Components: CMIS connector Reporter: JC Priority: Trivial Hi In a recent snapshot, I've found a suspicious code in connectors/cmis/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/cmis/CmisAuthorityConnector.java {code} 402 public boolean equals(Object o) 403 { 404 if (!(o instanceof AuthorizationResponseDescription)) 405 return false; 406 AuthorizationResponseDescription ard = (AuthorizationResponseDescription)o; 407 return ard.userName.equals(userName) && ard.endpoint.equals(endpoint) && 408 repositoryId.equals(repositoryId); 409 } {code} In Line 408, repositoryId.equals(repositoryId) should be repositoryId.equals(*ard*.repositoryId)? This might be a trivial issue but wanted to report just in case. Thanks! -- This message was sent by Atlassian JIRA (v6.3.15#6346)