Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 62EF6200B49 for ; Wed, 3 Aug 2016 13:22:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 619E5160A64; Wed, 3 Aug 2016 11:22:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A6698160AAA for ; Wed, 3 Aug 2016 13:22:21 +0200 (CEST) Received: (qmail 58120 invoked by uid 500); 3 Aug 2016 11:22:20 -0000 Mailing-List: contact dev-help@manifoldcf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@manifoldcf.apache.org Delivered-To: mailing list dev@manifoldcf.apache.org Received: (qmail 58034 invoked by uid 99); 3 Aug 2016 11:22:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 11:22:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 87FB42C0D64 for ; Wed, 3 Aug 2016 11:22:20 +0000 (UTC) Date: Wed, 3 Aug 2016 11:22:20 +0000 (UTC) From: "Karl Wright (JIRA)" To: dev@manifoldcf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CONNECTORS-1330) Organize LDAPAuthority Class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 Aug 2016 11:22:22 -0000 [ https://issues.apache.org/jira/browse/CONNECTORS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405750#comment-15405750 ] Karl Wright edited comment on CONNECTORS-1330 at 8/3/16 11:22 AM: ------------------------------------------------------------------ It's not clear to me that this patch offers much in the way of "organization". It seems to be a minor random refactoring that isn't really very much improved over what was present before. For example, introducing the enum doesn't seem to help anything that I can see except complexity. I will nevertheless look at it but I have no time today or tomorrow. Maybe Friday. was (Author: kwright@metacarta.com): It's not clear to me that this patch offers much in the way of "organization". It seems to be a minor random refactoring that isn't really very much improved over what was present before. For example, introducing the enum doesn't seem to help anything that I can see except complexity. > Organize LDAPAuthority Class > ---------------------------- > > Key: CONNECTORS-1330 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1330 > Project: ManifoldCF > Issue Type: Improvement > Components: LDAP authority > Affects Versions: ManifoldCF 2.4 > Reporter: Furkan KAMACI > Priority: Minor > Fix For: ManifoldCF 2.5 > > Attachments: CONNECTORS-1330.patch > > > LDAPAuthority class is not readable and should be organized for different server protocols. -- This message was sent by Atlassian JIRA (v6.3.4#6332)