Mailing-List: contact dev-help@manifoldcf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@manifoldcf.apache.org
Date: Mon, 15 Aug 2016 13:38:20 +0000 (UTC)
From: "Karl Wright (JIRA)" <jira@apache.org>
To: dev@manifoldcf.apache.org
Message-ID: <JIRA.12963225.1461779933000.304961.1471268300451@Atlassian.JIRA>
In-Reply-To: <JIRA.12963225.1461779933000@Atlassian.JIRA>
References: <JIRA.12963225.1461779933000@Atlassian.JIRA> <JIRA.12963225.1461779933342@arcas>
Subject: [jira] [Commented] (CONNECTORS-1304) ban usage of
 String.toUpperCase() without Locale
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 15 Aug 2016 13:38:22 -0000


    [ https://issues.apache.org/jira/browse/CONNECTORS-1304?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15420979#comment-15420979 ]=20

Karl Wright commented on CONNECTORS-1304:
-----------------------------------------

Looking at the way the forbiddenapis check is currently being done, I have =
to say we need to improve it before shipping it.

(1) The main target that does the work is in framework, but it doesn't actu=
ally do any work in framework.  It uses ".." paths everywhere.  It should b=
e moved to the main (outer) build file instead.
(2) The jar for doing the checks should not be downloaded to lib.
(3) The stuff that gets checked should mainly be in the "dist" directory pr=
oduced after the build target is run.  This has a downside that it may miss=
 test classes, which are not generally shipped.  But it's the right stuff t=
o check, rather than the whole tree.  Alternatively, we can do this not at =
the end but instead have *every* build.xml in the tree support the function=
ality.  That's more work but it would allow all test classes to be checked =
as well.

I'm putting together a change that will capture at least most of this.


> ban usage of String.toUpperCase() without Locale
> ------------------------------------------------
>
>                 Key: CONNECTORS-1304
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-130=
4
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: SearchBlox connector
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Ahmet Arslan
>            Assignee: Ahmet Arslan
>             Fix For: ManifoldCF 2.5
>
>
> When relied on the default Locale, toUpperCase() is not reliable. For exa=
mple: In SearchBloxConnector.java, "title_boost".toUpperCase() will yield {=
{T=C4=B0TLE_BOOST}} on Turkish Locale and won't match {{TITLE_BOOST}}. We s=
hould prevent this in a more permanent way. I would like to integrate Uwe's=
 [forbidden apis|https://github.com/policeman-tools/forbidden-apis] when I =
have time.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)