manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Furkan KAMACI (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1332) Check Forbidden APIs at Build
Date Fri, 12 Aug 2016 19:04:22 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419315#comment-15419315
] 

Furkan KAMACI commented on CONNECTORS-1332:
-------------------------------------------

[~kwright@metacarta.com] Tests classes are fixed too. i.e. you mentioned that MockSolrService
fails but check the patch file for it and you'll see its been included. I've tested all the
combinations as like just building with maven or ant or first maven than ant etc. or including
tests etc. (yes, it takes too much time :) ). Could you check it again?

Plugin is integrated as ant plugin. Its usage convention is that: build happens and than forbiddenapis
is run. So, its been triggered after ant build:

{code:xml}
    <target name="build" depends="deliver-connectors, forbidden-checks"/>
{code}

It covers and scans all the build data. On the other hand, I've considered the case at which
maven is run and than ant (please consider that ant clean does not clean maven targets as
well). So, I've excluded target folders of maven built to avoid double checking. Lastly, test-materials
module has a drawback which is run by maven. It uses aflresco 4.2.c and has FSDirectory (from
lucene) and has a forbbidden api call. Once its been fixed (i.e. version is upgraded), it
can be applied as a maven plugin too (one of the reasons that why I've removed my Maven plugin
improvement from patch).

> Check Forbidden APIs at Build
> -----------------------------
>
>                 Key: CONNECTORS-1332
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1332
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Furkan KAMACI
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 2.5
>
>         Attachments: CONNECTORS-1332.patch
>
>
> We should avoid [forbidden calls|https://github.com/policeman-tools/forbidden-apis/wiki]
 and check for it in the ant build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message