manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CONNECTORS-1330) Organize LDAPAuthority Class
Date Wed, 03 Aug 2016 11:22:20 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405750#comment-15405750
] 

Karl Wright edited comment on CONNECTORS-1330 at 8/3/16 11:22 AM:
------------------------------------------------------------------

It's not clear to me that this patch offers much in the way of "organization".  It seems to
be a minor random refactoring that isn't really very much improved over what was present before.
 For example, introducing the enum doesn't seem to help anything that I can see except complexity.

I will nevertheless look at it but I have no time today or tomorrow.  Maybe Friday.




was (Author: kwright@metacarta.com):
It's not clear to me that this patch offers much in the way of "organization".  It seems to
be a minor random refactoring that isn't really very much improved over what was present before.
 For example, introducing the enum doesn't seem to help anything that I can see except complexity.



> Organize LDAPAuthority Class
> ----------------------------
>
>                 Key: CONNECTORS-1330
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1330
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: LDAP authority
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Furkan KAMACI
>            Priority: Minor
>             Fix For: ManifoldCF 2.5
>
>         Attachments: CONNECTORS-1330.patch
>
>
> LDAPAuthority class is not readable and should be organized for different server protocols.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message