manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Arslan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1304) ban usage of String.toUpperCase() without Locale
Date Mon, 15 Aug 2016 16:17:21 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421211#comment-15421211
] 

Ahmet Arslan commented on CONNECTORS-1304:
------------------------------------------

I tried to convert ivy-bootstrap to rat-bootstrap by stealing the code from https://github.com/apache/lucene-solr/blob/master/lucene/common-build.xml
Here is my initial effort, beyond this exceeds my ant abilities. Furkan, could you please
take care of the rest?

{code:xml|title=rat-bootstrap}
  <property name="rat.bootstrap.version" value="0.12"/>
  <property name="rat_checksum_sha1" value="16398550402b27f81cd0d508cef54b3e47a4a6da"/>
  <property name="rat_install_path" location="${user.home}/.ant/lib" />
  <property name="rat_bootstrap_url1" value="http://repo1.maven.org/maven2"/>
  <!-- you might need to tweak this from china so it works -->
  <property name="rat_bootstrap_url2" value="http://uk.maven.org/maven2"/>
  
  
   <macrodef name="rat-download">
      <attribute name="src"/>
      <attribute name="dest"/>
    <sequential>
      <mkdir dir="@{dest}"/>
      <echo message="installing rat ${rat.bootstrap.version} to ${rat_install_path}"/>
      <get src="@{src}/org/apache/rat/apache-rat/${rat.bootstrap.version}/rat-${rat.bootstrap.version}.jar"
           dest="@{dest}/apache-rat-${rat.bootstrap.version}.jar" usetimestamp="true" ignoreerrors="true"/>
    </sequential>
  </macrodef>
  
<target name="rat-bootstrap" description="Download and install rat in the users ant lib
dir" depends="rat-bootstrap1,rat-bootstrap2,rat-checksum"/>

  <!-- try to download from repo1.maven.org -->
  <target name="rat-bootstrap1">
    <rat-download src="${rat_bootstrap_url1}" dest="${rat_install_path}"/>
    <available file="${rat_install_path}/apache-rat-${rat.bootstrap.version}.jar" property="rat.bootstrap1.success"
/>
  </target> 

  <target name="rat-bootstrap2" unless="rat.bootstrap1.success">
    <rat-download src="${rat_bootstrap_url2}" dest="${rat_install_path}"/>
  </target>

  <target name="rat-checksum">
    <checksum file="${rat_install_path}/apache-rat-${rat.bootstrap.version}.jar"
              property="${rat_checksum_sha1}"
              algorithm="SHA"
              verifyproperty="rat.checksum.success"/>
    <fail message="Checksum mismatch for apache-rat-${rat.bootstrap.version}.jar. Please
download this file manually">
      <condition>
        <isfalse value="${rat.checksum.success}"/>
      </condition>
    </fail>
  </target>
{{code}}

> ban usage of String.toUpperCase() without Locale
> ------------------------------------------------
>
>                 Key: CONNECTORS-1304
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1304
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: SearchBlox connector
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Ahmet Arslan
>            Assignee: Ahmet Arslan
>             Fix For: ManifoldCF 2.5
>
>
> When relied on the default Locale, toUpperCase() is not reliable. For example: In SearchBloxConnector.java,
"title_boost".toUpperCase() will yield {{TÄ°TLE_BOOST}} on Turkish Locale and won't match
{{TITLE_BOOST}}. We should prevent this in a more permanent way. I would like to integrate
Uwe's [forbidden apis|https://github.com/policeman-tools/forbidden-apis] when I have time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message