manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1304) ban usage of String.toUpperCase() without Locale
Date Mon, 15 Aug 2016 13:38:20 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420979#comment-15420979
] 

Karl Wright commented on CONNECTORS-1304:
-----------------------------------------

Looking at the way the forbiddenapis check is currently being done, I have to say we need
to improve it before shipping it.

(1) The main target that does the work is in framework, but it doesn't actually do any work
in framework.  It uses ".." paths everywhere.  It should be moved to the main (outer) build
file instead.
(2) The jar for doing the checks should not be downloaded to lib.
(3) The stuff that gets checked should mainly be in the "dist" directory produced after the
build target is run.  This has a downside that it may miss test classes, which are not generally
shipped.  But it's the right stuff to check, rather than the whole tree.  Alternatively, we
can do this not at the end but instead have *every* build.xml in the tree support the functionality.
 That's more work but it would allow all test classes to be checked as well.

I'm putting together a change that will capture at least most of this.


> ban usage of String.toUpperCase() without Locale
> ------------------------------------------------
>
>                 Key: CONNECTORS-1304
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1304
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: SearchBlox connector
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Ahmet Arslan
>            Assignee: Ahmet Arslan
>             Fix For: ManifoldCF 2.5
>
>
> When relied on the default Locale, toUpperCase() is not reliable. For example: In SearchBloxConnector.java,
"title_boost".toUpperCase() will yield {{TÄ°TLE_BOOST}} on Turkish Locale and won't match
{{TITLE_BOOST}}. We should prevent this in a more permanent way. I would like to integrate
Uwe's [forbidden apis|https://github.com/policeman-tools/forbidden-apis] when I have time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message