manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Schuch (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CONNECTORS-1296) Email notification connector doesn't work properly for SMTP
Date Fri, 15 Apr 2016 21:49:25 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243715#comment-15243715
] 

Markus Schuch edited comment on CONNECTORS-1296 at 4/15/16 9:48 PM:
--------------------------------------------------------------------

Thanks for the patch. Applied it and did some testing and reviewed the parameters.

Setting the properties {{mail.smtp.auth=true}} and {{mail.smtp.starttls.enable=true}} seems
not ideal. I suggest setting {{mail.smtp.auth=true}} only if credentials are given, even though
i had no problems with unauthenticated send request in my tests. The property {{mail.smtp.starttls.enable=true}}
should be overridable, but i like the idea to default to starttls.

There are also some timeout properties that default to infinity. It may be a good idea to
set those to a more reasonable default value if they are not specified in the notification
configuration. ({{mail.smtp.connectiontimeout}}, {{mail.smtp.timeout}}, {{mail.smtp.writetimeout}})

My Tests:
- Tested OK with https://github.com/Jaben/Papercut on port 25 (no TLS) and without credentials.
The parameters {{mail.smtp.auth=true}} and {{mail.smtp.starttls.enable=true}} were no problem
in this case
- Tested OK on mailtrap.io (supports both no-TLS and TLS). {{mail.smtp.starttls.enable=true}}
triggered TLS usage. Needed to specify {{mail.smtp.ssl.trust}} due to unknown certificate
path issue.


was (Author: schuchm):
Setting the properties {{mail.smtp.auth=true}} and {{mail.smtp.starttls.enable=true}} seems
not ideal. I suggest setting {{mail.smtp.auth=true}} only if credentials are given, even though
i had no problems with unauthenticated send request in my tests. The property {{mail.smtp.starttls.enable=true}}
should be overridable, but i like the idea to default to starttls.

There are also some timeout properties that default to infinity. It may be a good idea to
set those to a more reasonable default value if they are not specified in the notification
configuration. ({{mail.smtp.connectiontimeout}}, {{mail.smtp.timeout}}, {{mail.smtp.writetimeout}})

My Tests:
- Tested OK with https://github.com/Jaben/Papercut on port 25 (no TLS) and without credentials.
The parameters {{mail.smtp.auth=true}} and {{mail.smtp.starttls.enable=true}} were no problem
in this case
- Tested OK on mailtrap.io (supports both no-TLS and TLS). {{mail.smtp.starttls.enable=true}}
triggered TLS usage. Needed to specify {{mail.smtp.ssl.trust}} due to unknown certificate
path issue.

> Email notification connector doesn't work properly for SMTP
> -----------------------------------------------------------
>
>                 Key: CONNECTORS-1296
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1296
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Email connector
>    Affects Versions: ManifoldCF 2.3
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 2.4
>
>         Attachments: CONNECTORS-1296.patch
>
>
> You can't configure the email connector to work with SMTP; it fails trying to establish
an IMAP or POP connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message