manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rafa Haro <rh...@apache.org>
Subject Re: Chalitha's OpenNLP Transformation Connector Contribution
Date Tue, 26 Jan 2016 15:49:25 GMT
Hi all,

I have imported Chalitha's OpenNLP connector to a branch: You can checkout
it here:
https://svn.apache.org/repos/asf/manifoldcf/branches/CONNECTORS-1270

License files and ant build are still lacking

Thanks a lot Chalitha for the contribution.

On Tue, Jan 26, 2016 at 1:48 PM Rafa Haro <rharo@apache.org> wrote:

> Ok,
>
> For this I would need Chalitha to fork the current Manifold's repo in
> github, put the connector in the correct place in his fork and made the
> pull request.
>
> @Chalitha, if you are available to do this in a short period of time, it
> would be nice. If you are currently busy I can take care or just go through
> the classical "manual" process
>
> Cheers,
> Rafa
>
> On Tue, Jan 26, 2016 at 1:38 PM Karl Wright <daddywri@gmail.com> wrote:
>
>> Hi Rafa,
>>
>> I am fine with that approach if you want to try it.
>>
>> Karl
>>
>>
>> On Tue, Jan 26, 2016 at 7:34 AM, Rafa Haro <rharo@apache.org> wrote:
>>
>> > Hi Chalitha,
>> >
>> > I have created a branch for contributing the connector but probably you
>> > should first merge your develop branch into the master branch because
>> it is
>> > better for me to work against the master branch.
>> >
>> > @karl: I'm ready for importing this at SVN level (I already have
>> locally a
>> > OpenNlpTransformationConnector branch) but, would not be better to
>> receive
>> > a pull request at GitHub from Chalitha now that we know how to quickly
>> get
>> > a Git pull request imported to the SVN repo?
>> >
>> > Cheers,
>> > Rafa
>> >
>> > On Tue, Jan 26, 2016 at 12:07 PM Karl Wright <daddywri@gmail.com>
>> wrote:
>> >
>> > > Any news on this?
>> > > Karl
>> > >
>> > >
>> > > On Fri, Jan 22, 2016 at 7:26 AM, Karl Wright <daddywri@gmail.com>
>> wrote:
>> > >
>> > > > " I think I can proceed to create a branch for this and start the
>> > > > merge process. What do you think?"
>> > > >
>> > > > I agree.  Once you have a branch, please let me know and I'll see
>> about
>> > > > licensing of dependencies etc.  Will you be integrating the ant
>> build?
>> > > >
>> > > > Karl
>> > > >
>> > > >
>> > > > On Fri, Jan 22, 2016 at 7:10 AM, Rafa Haro <rharo@apache.org>
>> wrote:
>> > > >
>> > > >> Hi Chalitha,
>> > > >>
>> > > >> I have reviewed the code and my opinion right now is quite ok
for a
>> > > first
>> > > >> release. I still have to build it and check the UI, but from the
>> code
>> > > >> seems
>> > > >> to be enough for configuring the models paths. Could you provide
a
>> > > >> screenshot of the configuration?
>> > > >>
>> > > >> @Karl, I think I can proceed to create a branch for this and start
>> the
>> > > >> merge process. What do you think?
>> > > >>
>> > > >> Cheers,
>> > > >> Rafa
>> > > >>
>> > > >> On Mon, Jan 18, 2016 at 4:01 PM Rafa Haro <rharo@apache.org>
>> wrote:
>> > > >>
>> > > >> > Hi Chalitha,
>> > > >> >  I will review it this week and let you know something here.
>> > > >> >
>> > > >> > Cheers,
>> > > >> > Rafa
>> > > >> >
>> > > >> > On Sat, Jan 16, 2016 at 11:20 AM chalitha udara Perera <
>> > > >> > chalithaudara@gmail.com> wrote:
>> > > >> >
>> > > >> >> Hi Rafa and Karl,
>> > > >> >>
>> > > >> >> I have externalise the model configuration and now user
can
>> provide
>> > > >> model
>> > > >> >> location from Job configuration UI.
>> > > >> >> Connector code is avaliable in [1].
>> > > >> >> Please have a look when you have some time.
>> > > >> >>
>> > > >> >> [1]
>> > > >> >>
>> > > >>
>> > >
>> https://github.com/ChalithaUdara/OpenNLP-Manifold-Connector/tree/develop
>> > > >> >>
>> > > >> >> Thanks,
>> > > >> >> Chalitha
>> > > >> >>
>> > > >> >> On Sun, Dec 20, 2015 at 11:23 AM, chalitha udara Perera
<
>> > > >> >> chalithaudara@gmail.com> wrote:
>> > > >> >>
>> > > >> >> > Hi Rafa and Karl,
>> > > >> >> >
>> > > >> >> > To give more flexibility, It make sense to externalize
models
>> and
>> > > go
>> > > >> >> with
>> > > >> >> > configuration information.
>> > > >> >> > I'll modify the connector, so that users can provide
models.
>> > > >> >> >
>> > > >> >> > Thanks,
>> > > >> >> > Chalitha
>> > > >> >> >
>> > > >> >> > On Fri, Dec 18, 2015 at 5:30 PM, Karl Wright <
>> daddywri@gmail.com
>> > >
>> > > >> >> wrote:
>> > > >> >> >
>> > > >> >> >> If the models are immutable resources, then
we should
>> probably
>> > > just
>> > > >> >> bundle
>> > > >> >> >> them in the jar as resources.  If they are modifiable
and/or
>> it
>> > is
>> > > >> >> >> expected
>> > > >> >> >> that the user will supply their own, then configuration
>> > > information
>> > > >> is
>> > > >> >> the
>> > > >> >> >> way to go.
>> > > >> >> >>
>> > > >> >> >> Karl
>> > > >> >> >>
>> > > >> >> >>
>> > > >> >> >> On Fri, Dec 18, 2015 at 6:58 AM, Karl Wright
<
>> > daddywri@gmail.com>
>> > > >> >> wrote:
>> > > >> >> >>
>> > > >> >> >> > Hi Rafa,
>> > > >> >> >> >
>> > > >> >> >> > I'm also not really happy with how the
connector locates
>> the
>> > > >> models.
>> > > >> >> >> It's
>> > > >> >> >> > not going to work very well in a distributed
environment.
>> It
>> > > >> seems
>> > > >> >> like
>> > > >> >> >> > there's a missing piece here: the models
should probably be
>> > > >> imported
>> > > >> >> as
>> > > >> >> >> > part of the connection's configuration
information, rather
>> > than
>> > > >> just
>> > > >> >> an
>> > > >> >> >> > implicit file reference.  How big are these
model files,
>> > > >> typically?
>> > > >> >> >> >
>> > > >> >> >> > Karl
>> > > >> >> >> >
>> > > >> >> >> >
>> > > >> >> >> > On Fri, Dec 18, 2015 at 6:53 AM, Karl Wright
<
>> > > daddywri@gmail.com>
>> > > >> >> >> wrote:
>> > > >> >> >> >
>> > > >> >> >> >> Yes, please create a ticket.  But I'd
create a branch and
>> > > import
>> > > >> the
>> > > >> >> >> code
>> > > >> >> >> >> into that first.  I have to get licenses
and build process
>> > > >> working
>> > > >> >> >> before
>> > > >> >> >> >> we can bring everything into trunk.
>> > > >> >> >> >>
>> > > >> >> >> >> Thanks,
>> > > >> >> >> >> Karl
>> > > >> >> >> >>
>> > > >> >> >> >>
>> > > >> >> >> >> On Fri, Dec 18, 2015 at 6:38 AM, Rafa
Haro <
>> rharo@apache.org
>> > >
>> > > >> >> wrote:
>> > > >> >> >> >>
>> > > >> >> >> >>> Hi all,
>> > > >> >> >> >>>
>> > > >> >> >> >>> I was about to open a Jira ticket
for including
>> Chalitha's
>> > > >> OpenNLP
>> > > >> >> >> >>> Transformation Connector (
>> > > >> >> >> >>>
>> https://github.com/ChalithaUdara/OpenNLP-Manifold-Connector
>> > )
>> > > >> into
>> > > >> >> the
>> > > >> >> >> >>> trunk.
>> > > >> >> >> >>>
>> > > >> >> >> >>> Everyone agree?
>> > > >> >> >> >>>
>> > > >> >> >> >>> Cheers,
>> > > >> >> >> >>> Rafa
>> > > >> >> >> >>>
>> > > >> >> >> >>
>> > > >> >> >> >>
>> > > >> >> >> >
>> > > >> >> >>
>> > > >> >> >
>> > > >> >> >
>> > > >> >> >
>> > > >> >> > --
>> > > >> >> > J.M Chalitha Udara Perera
>> > > >> >> >
>> > > >> >> > *Department of Computer Science and Engineering,*
>> > > >> >> > *University of Moratuwa,*
>> > > >> >> > *Sri Lanka*
>> > > >> >> >
>> > > >> >>
>> > > >> >>
>> > > >> >>
>> > > >> >> --
>> > > >> >> J.M Chalitha Udara Perera
>> > > >> >>
>> > > >> >> *Department of Computer Science and Engineering,*
>> > > >> >> *University of Moratuwa,*
>> > > >> >> *Sri Lanka*
>> > > >> >>
>> > > >> >
>> > > >>
>> > > >
>> > > >
>> > >
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message