manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bartłomiej Superson (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-642) Need an ElasticSearch plugin for enforcing ManifoldCF security
Date Wed, 01 Jul 2015 18:33:04 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610790#comment-14610790
] 

Bartłomiej Superson commented on CONNECTORS-642:
------------------------------------------------

And about README.txt - it looks good, but I would modify this:
{quote}
The JAR packages can be found in the target folder:

target/elasticsearch-1.5-plugin-mcf-<VERSION>.jar

... where <VERSION> is the release version
{quote}
to
{quote}
The JAR packages can be found in the target folder:

target/elasticsearch-1.5-plugin-mcf-<VERSION>-jar-with-dependencies.jar

... where <VERSION> is the release version
{quote}
or change the name of the package with dependencies to elasticsearch-1.5-plugin-mcf-<VERSION>.jar,
because JAR without dependencies won't work properly with ES. And I propose to change _mvn
install_ command to _mvn clean install_ .

Also I would change order in the usage section: I propose to mention firstly about the configuration
and how to invoke ElasticSearch to provide security (also there should be added that without
the _u_ parameter search won't be filtered) and then about the integration with e.g. Spring
(there should be mentioned that this example is prepared in Spring).

I propose also to change the *_all* from http://<ElasticSearch_Host_And_Port/_all/_search?u=<user>
to *<indexName>*, because it works not only on all indexes but also user can provide
the name of the index to search in.

> Need an ElasticSearch plugin for enforcing ManifoldCF security
> --------------------------------------------------------------
>
>                 Key: CONNECTORS-642
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-642
>             Project: ManifoldCF
>          Issue Type: New Feature
>          Components: Elastic Search connector
>    Affects Versions: ManifoldCF 1.1
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 1.2
>
>         Attachments: CONNECTORS-642_-_read_config_parameters_from_ElasticSearch_config_file.patch
>
>
> ElasticSearch is becoming popular and we need to support it fully.  In order for that
to happen, we really need an ElasticSearch ManifoldCF plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message