Return-Path: 
 <dev-return-13973-apmail-manifoldcf-dev-archive=manifoldcf.apache.org@manifoldcf.apache.org>
X-Original-To: apmail-manifoldcf-dev-archive@www.apache.org
Delivered-To: apmail-manifoldcf-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BEBFC17CD2
	for <apmail-manifoldcf-dev-archive@www.apache.org>;
 Wed, 24 Jun 2015 14:34:09 +0000 (UTC)
Received: (qmail 44821 invoked by uid 500); 24 Jun 2015 14:34:09 -0000
Delivered-To: apmail-manifoldcf-dev-archive@manifoldcf.apache.org
Received: (qmail 44761 invoked by uid 500); 24 Jun 2015 14:34:09 -0000
Mailing-List: contact dev-help@manifoldcf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@manifoldcf.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@manifoldcf.apache.org>
List-Post: <mailto:dev@manifoldcf.apache.org>
List-Id: <dev.manifoldcf.apache.org>
Reply-To: dev@manifoldcf.apache.org
Delivered-To: mailing list dev@manifoldcf.apache.org
Received: (qmail 44545 invoked by uid 99); 24 Jun 2015 14:34:09 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 14:34:09 +0000
Date: Wed, 24 Jun 2015 14:34:09 +0000 (UTC)
From: "Karl Wright (JIRA)" <jira@apache.org>
To: dev@manifoldcf.apache.org
Message-ID: <JIRA.12840213.1435154696000.2506.1435156449468@Atlassian.JIRA>
In-Reply-To: <JIRA.12840213.1435154696000@Atlassian.JIRA>
References: <JIRA.12840213.1435154696000@Atlassian.JIRA>
 <JIRA.12840213.1435154696226@arcas>
Subject: [jira] [Commented] (CONNECTORS-1215) Tag parsing in script tags
 shouldn't recognize "<" but does
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CONNECTORS-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599497#comment-14599497 ] 

Karl Wright commented on CONNECTORS-1215:
-----------------------------------------

The issue is complex because according to spec the code is doing the right thing.  Typically, <script> blocks look something like this:

{code}
<script ...>
<!--

...

//-->
</script>
{code}

The reason for the comment area is because without it, tags within the script block are supposed to be recognized as such, even if they are ignored.  Within comments, this does not happen, of course, which is why comments are used.

I don't believe it is a real standard, but some browsers try to interpret script blocks differently even when no comment is given.  We can try to emulate that behavior but it is likely that our emulation will not work for all web pages, since it's not a standard.  Exploring how this works on various browsers would be the first step.  Specifically, if you do something like this:

{code}
<script ...>

foo = "<script></script>";
bar = "hello";

</script>
{code}


... what happens?  Does the script end at the first </script>, or the second?  And, in what browsers?

Until we get more clarity it's going to be hard to do a feature that actually helps rather than hurts...

> Tag parsing in script tags shouldn't recognize "<" but does
> -----------------------------------------------------------
>
>                 Key: CONNECTORS-1215
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1215
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Web connector
>    Affects Versions: ManifoldCF 1.9, ManifoldCF 2.1
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 1.10, ManifoldCF 2.2
>
>
> User says:
> "There appears to be a bug in the TagParseState when the comparison operator '<'  is encountered in the body of  a script tag.  It appears to get flagged as an open tag and then the next '</' closes it.  In my case, the next '</' is the script tag.  The ScriptParseState chomps everything until it encounters a second </script> tag.
> A live link that demonstrates this bug is here:
> http://www.prnewswire.com/search-results/news/Google%252C%2520Inc.-30-days-page-1-pagesize-20
> The '<' near line 2826 in the script body that begins near   line 2759 begins a new tag 'arraykeywords.length' which gets closed by the '</' in the closing script tag.  The ScriptParseState chomps all the html until it sees the end script tag near line 3385.
> At the moment, I'm not sure of a solution other than pushing the script tag handling up to the TagParseState and treating it like CDATA is."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)