manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1160) Update Livelink Connector HTML String to Velocity Template
Date Tue, 03 Mar 2015 00:14:04 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344107#comment-14344107
] 

Karl Wright commented on CONNECTORS-1160:
-----------------------------------------

Here's what I've found:

(1) First of all, it would help your naming of html and js files to call the ones related
to jobs "Specification" rather than "Configuration".  Not a big deal but it's confusing.

(2) The "editConfiguration_Job_Body.html" file is empty except for the copyright header. 
Is this intentional?  This should be completed before the branch is committed to trunk.  There
are a number of techniques for handling more complex content which you can learn by looking
at (for example) the SharePoint connector.

(3) The following expression seems overly complicated; I'd look at how https keystores are
handled in other connectors that support them, if you can find one that is written with Velocity:

{code}
#if(!(! $serverHTTPSKeystore) && ("$!serverHTTPSKeystore" == ""))
<input type="hidden" name="serverhttpskeystoredata" value="$Encoder.attributeEscape($serverHTTPSKeystore)"/>
#end
{code}

For changes going forward, please submit patches based on the current contents of the CONNECTORS-1160
branch.  I can apply the patch and commit.  Thanks!



> Update Livelink Connector HTML String to Velocity Template
> ----------------------------------------------------------
>
>                 Key: CONNECTORS-1160
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1160
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: LiveLink connector
>    Affects Versions: ManifoldCF 2.0.1
>            Reporter: Kishore Kumar
>            Assignee: Karl Wright
>            Priority: Minor
>              Labels: connector, patch, velocity
>             Fix For: ManifoldCF 2.1
>
>         Attachments: CONNECTORS-1160.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Hi [~kwright@metacarta.com]
> I would like to contribute to Livelink connector by replacing all stringified html into
velocity templates, if you think that is possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message