manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-1077) Add activity logging for decision and exception events across all connectors
Date Sun, 19 Oct 2014 15:55:33 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176328#comment-14176328
] 

Karl Wright commented on CONNECTORS-1077:
-----------------------------------------

Hi Muhammed,

Reviewing your commits, for r1632844 I note the following change:

{code}
           }
           // Probably some other error
+          activities.recordActivity(null, INGEST_ACTIVITY, new Long(document.getBinaryLength()),
documentURI, activities.EXCEPTION, "Rejected due to FileNotFoundException.");
           throw new ManifoldCFException("Could not create file '"+outputPath+"': "+e.getMessage(),e);
         }
       }
{code}

In this case, the description ("Rejected due to FileNotFoundException") is misleading.  The
document has not been rejected; instead the entire job has been aborted.  (That's what throwing
a ManifoldCFException means, and the exception message will be reported in the UI as the reason
for the job failure.)  So, please be sure to include in the record of activity enough detailed
information for someone to be able to diagnose the problem, such as the exception text, e.g:

"Failed to write document due to: "+e.getMessage()

Could you review your commits for this ticket carefully and make sure that your fixes seem
correct in this way?  Thanks!


> Add activity logging for decision and exception events across all connectors
> ----------------------------------------------------------------------------
>
>                 Key: CONNECTORS-1077
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1077
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Alfresco connector
>    Affects Versions: ManifoldCF 2.0
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 2.0
>
>
> Many document skip decisions or transient exceptions are only logged, and are not recorded
as history events.  This makes it necessary upon occasion to refer to the manifoldcf log for
basic diagnosis.  We should record activity events for most decisions and exceptions in the
history.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message