manifoldcf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONNECTORS-224) OpenSearchServer connector
Date Fri, 12 Aug 2011 17:04:27 GMT

    [ https://issues.apache.org/jira/browse/CONNECTORS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084252#comment-13084252
] 

Karl Wright commented on CONNECTORS-224:
----------------------------------------

Ok, I've tested some more.

This is a lot better than before.  The issues previously described seem to have been fixed.
 Now we have a new set of issues to consider.  I'm listing these below.

(1) In addOrReplaceDocument(), the following code is present:

>>>>>>
		OpenSearchServerConfig config = getConfigParameters(null);
		Integer count = addInstance(config);
		synchronized (count) {
<<<<<<

Can you explain what the purpose of this synchronizer is?  It looks to me like you might be
effectively managing your own connection pool here, which is both redundant and would prevent
ManifoldCF end users from controlling the size of that pool.  Am I correct?

(2) In addOrReplaceDocument(), you close the input stream.  You should not do that.  The caller
closes the stream.

(3) Formatting.  Apache guidelines set indenting to 2 spaces, with no tabs.  ManifoldCF adheres
to this convention.  It would be great if you could reformat accordingly.

Thanks again!


> OpenSearchServer connector
> --------------------------
>
>                 Key: CONNECTORS-224
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-224
>             Project: ManifoldCF
>          Issue Type: New Feature
>          Components: OpenSearchServer connector
>    Affects Versions: ManifoldCF 0.3
>            Reporter: Emmanuel Keller
>            Assignee: Karl Wright
>              Labels: OpenSearchServer, connector, outputconnector
>         Attachments: oss-mfc-alpha.patch, oss-mfc-alpha2.patch, oss-mfc-beta.patch, oss-mfc-dev.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Provide an output connector for [OpenSearchServer|http://www.open-search-server.com].

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message