mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-1660) Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
Date Thu, 11 Jun 2015 19:58:04 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582434#comment-14582434
] 

ASF GitHub Bot commented on MAHOUT-1660:
----------------------------------------

Github user dlyubimov commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/135#discussion_r32261115
  
    --- Diff: math-scala/src/main/scala/org/apache/mahout/math/drm/DistributedEngine.scala
---
    @@ -119,38 +140,49 @@ object DistributedEngine {
       private def pass1[K: ClassTag](action: DrmLike[K]): DrmLike[K] = {
     
         action match {
    -      case OpAB(OpAt(a), b) if (a == b) => OpAtA(pass1(a))
    -      case OpABAnyKey(OpAtAnyKey(a), b) if (a == b) => OpAtA(pass1(a))
    +
    +      // self element-wise rewrite
    +      case OpAewB(a, b, op) if (a == b) => {
    --- End diff --
    
    I am using the unicode chars now (change of style that happened to me a few months ago)
but it has not gone over the entire codebase. We probably may want to standardize on this
(later) but for now i just keep style consistent with the rest of the file. If i change the
style, i change the style in the whole file.


> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
> ----------------------------------------------------------
>
>                 Key: MAHOUT-1660
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1660
>             Project: Mahout
>          Issue Type: Bug
>          Components: spark
>    Affects Versions: 0.10.0
>            Reporter: Suneel Marthi
>            Assignee: Dmitriy Lyubimov
>            Priority: Minor
>             Fix For: 0.10.2
>
>
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop configuration from Context and
not ignore it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message