mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-1622) MultithreadedBatchItemSimilarities outputs incorrect number of similarities.
Date Sun, 05 Apr 2015 06:30:33 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396111#comment-14396111
] 

ASF GitHub Bot commented on MAHOUT-1622:
----------------------------------------

Github user smarthi commented on the pull request:

    https://github.com/apache/mahout/pull/106#issuecomment-89727191
  
    Patch looks good to ship, would appreciate if u could update the codebase for Java 7.
Remove calls to guava collections like Lists, Maps etc and replace them by Java 7 constructs.


> MultithreadedBatchItemSimilarities outputs incorrect number of similarities.
> ----------------------------------------------------------------------------
>
>                 Key: MAHOUT-1622
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1622
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering
>    Affects Versions: 0.9
>            Reporter: Jesse Daniels
>            Assignee: Anand Avati
>            Priority: Minor
>              Labels: legacy
>             Fix For: 0.10.0
>
>         Attachments: batchSimilarities.patch
>
>
> In some cases the Output class in MultithreadedBatchItemSimilarities does not output
all of the similarity pairs that it should. It is very possible for the number of active workers
to go to zero while in the while loop, in which case the remaining similarities for the finished
workers will not be flushed to the output. This is because the while loop is only conditioned
on whether there are active workers or not. An easy fix is to also check to make sure the
results structure is not empty. This way both the number of active workers must be 0 and the
result set must be empty to exit the while loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message