mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pat Ferrel <...@occamsmachete.com>
Subject Re: [mahout] MAHOUT-1655 (#86)
Date Wed, 01 Apr 2015 19:45:18 GMT
Who cares about the branch logs, the master log is clear.

On Apr 1, 2015, at 12:41 PM, Pat Ferrel <pat@occamsmachete.com> wrote:

Here is my history dump something wrong here?

  608  git checkout master
  609  git pull apache master
  610  git merge --squash suneel
  611  git log
  612  git status
  613  mvn clean install
  614  nano CHANGELOG 
  615  git commit -a -m "MAHOUT-1655 Refactors mr-legacy into mahout-hdfs and mahout-mr, closes
apache/mahout#86"
  616  git status
  617  git pull apache master
  620  git push apache master

On Apr 1, 2015, at 11:53 AM, Dmitriy Lyubimov <notifications@github.com <mailto:notifications@github.com>>
wrote:

yeah. https://github.com/apache/mahout/commits/master <https://github.com/apache/mahout/commits/master>.

we should not see "merged master" commits there (clear sign of not
squashing your personal PR history! )


On Wed, Apr 1, 2015 at 11:26 AM, Suneel Marthi <notifications@github.com <mailto:notifications@github.com>>
wrote:

> r we not squashing the PRs before committing ??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/mahout/pull/86#issuecomment-88585219 <https://github.com/apache/mahout/pull/86#issuecomment-88585219>>.
>
—
Reply to this email directly or view it on GitHub <https://github.com/apache/mahout/pull/86#issuecomment-88593728>.




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message