Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mahout.apache.org
Date: Fri, 8 Aug 2014 22:00:13 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@mahout.apache.org
Message-ID: <JIRA.12704106.1395954928280.46928.1407535213088@arcas>
In-Reply-To: <JIRA.12704106.1395954928280@arcas>
References: <JIRA.12704106.1395954928280@arcas>
Subject: [jira] [Commented] (MAHOUT-1493) Port Naive Bayes to the Spark DSL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAHOUT-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091351#comment-14091351 ] 

ASF GitHub Bot commented on MAHOUT-1493:
----------------------------------------

Github user andrewpalumbo commented on the pull request:

    https://github.com/apache/mahout/pull/32#issuecomment-51662654
  
    I made most of the changes from Dmitriy's comments.  I've done some (hackish) work here just to get this in the right package, compiling and and testing.  Changed the Array[DrmLike] to DrmLike for the sparse feature input (for now).  This is very basic and assumes that each row correspnds to a unique label.  The only real engine specific DRM work right now is done in:
    
        val weightsPerFeature = observationsPerLabel.colSums
    
    I've added a Spark test suite with a test for a skeleton NB model. Tests pass here on Spark.   I've also added an h2o test suite on my MAHOUT-1493-1500 branch with relativly minimal effort (had to make a few dependency changes to the h20/pom.xml). h2o tests pass.
    
    Obviously there is still a lot of work to do here and it won't be ready to merge anytime soon, so I'll leave this PR open for a little while in case anybody's interested and then close it until i have some more work done on it as to not clog up the PR page. 
    
          
> Port Naive Bayes to the Spark DSL
> ---------------------------------
>
>                 Key: MAHOUT-1493
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1493
>             Project: Mahout
>          Issue Type: Bug
>          Components: Classification
>            Reporter: Sebastian Schelter
>            Assignee: Sebastian Schelter
>             Fix For: 1.0
>
>         Attachments: MAHOUT-1493.patch, MAHOUT-1493.patch, MAHOUT-1493.patch, MAHOUT-1493.patch, MAHOUT-1493a.patch
>
>
> Port our Naive Bayes implementation to the new spark dsl. Shouldn't require more than a few lines of code.


--
This message was sent by Atlassian JIRA
(v6.2#6252)