mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Awasthi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-1385) Caching Encoders don't cache
Date Sun, 18 May 2014 11:52:14 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001056#comment-14001056
] 

Manoj Awasthi commented on MAHOUT-1385:
---------------------------------------

[~ssc] Attached patch fixes this issue. But as [~baunz] mentions above and as far as I could
get it - this is suboptimal. I do not have a better patch as of now. So to fix the issue,
we may commit this one and track the task of making it better (if someone has ideas on that)
with a new JIRA ticket. 

> Caching Encoders don't cache
> ----------------------------
>
>                 Key: MAHOUT-1385
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1385
>             Project: Mahout
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Johannes Schulte
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: MAHOUT-1385-test.patch, MAHOUT-1385.patch
>
>
> The Caching... line of encoders contains code of caching the hash code terms added to
the vector. However, the method "hashForProbe" inside this classes is never called as the
signature has String for the parameter original form (instead of byte[] like other encoders).
> Changing this to byte[] however would lose the java String internal caching of the Strings
hash code , that is used as a key in the cache map, triggering another hash code calculation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message