Return-Path: X-Original-To: apmail-mahout-dev-archive@www.apache.org Delivered-To: apmail-mahout-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 469A210F68 for ; Mon, 20 Jan 2014 03:07:28 +0000 (UTC) Received: (qmail 68808 invoked by uid 500); 20 Jan 2014 03:07:25 -0000 Delivered-To: apmail-mahout-dev-archive@mahout.apache.org Received: (qmail 68161 invoked by uid 500); 20 Jan 2014 03:07:23 -0000 Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mahout.apache.org Delivered-To: mailing list dev@mahout.apache.org Received: (qmail 68137 invoked by uid 99); 20 Jan 2014 03:07:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jan 2014 03:07:22 +0000 Date: Mon, 20 Jan 2014 03:07:22 +0000 (UTC) From: "Roy Guo (JIRA)" To: dev@mahout.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (MAHOUT-1398) FileDataModel should provide a constructor with a delimiterPattern MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAHOUT-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876107#comment-13876107 ] Roy Guo edited comment on MAHOUT-1398 at 1/20/14 3:06 AM: ---------------------------------------------------------- [~smarthi], Thanks for your reminding, I'm new to mahout and I just checkout the mahout trunk from SVN. I see currently the CHANGELOG file is all about version 0.9, do you know where should I push my patch now ? Thanks. I just attach my patch in this issue, don't know if its the correct way. was (Author: royguo1988): [~smarthi], Thanks for your reminding, I'm new to mahout and I just checkout the mahout trunk from SVN. I see currently the CHANGELOG file is all about version 0.9, do you know where should I push my patch now ? Thanks. > FileDataModel should provide a constructor with a delimiterPattern > ------------------------------------------------------------------ > > Key: MAHOUT-1398 > URL: https://issues.apache.org/jira/browse/MAHOUT-1398 > Project: Mahout > Issue Type: Improvement > Components: Collaborative Filtering > Affects Versions: 0.9 > Reporter: Roy Guo > Priority: Minor > Fix For: 1.0 > > Attachments: MAHOUT-1398.patch > > > For now we only have ',' and '\t' as delimiters, this is really not enough for users. > Of course users can overwritten processLine etc. to archive their goal(e.g. use four spaces as delimiter pattern), but as a well designed framework, Mahout should consider vary demands of most users and make it very easy to use. > Also, it will not cost much time to implement, can I push a patch on this ? -- This message was sent by Atlassian JIRA (v6.1.5#6160)