mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Frank Scholten (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-1345) Enable randomised testing for all Mahout modules
Date Sun, 24 Nov 2013 19:10:36 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831014#comment-13831014
] 

Frank Scholten commented on MAHOUT-1345:
----------------------------------------

OK so now I reached the lucene2seq test and added a ThreadLeakLingering(linger=1000) annotation
on it but I get:

{code}
19:46:38 Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.492 sec <<<
FAILURE! - in org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest
19:46:38 testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
 Time elapsed: 2.925 sec  <<< ERROR!
19:46:38 com.carrotsearch.randomizedtesting.ThreadLeakError: 2 threads leaked from TEST scope
at testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest): 
19:46:38    1) Thread[id=23, name=communication thread, state=TIMED_WAITING, group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
19:46:38         at java.lang.Object.wait(Native Method)
19:46:38         at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
19:46:38         at java.lang.Thread.run(Thread.java:724)
19:46:38    2) Thread[id=24, name=communication thread, state=TIMED_WAITING, group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
19:46:38         at java.lang.Object.wait(Native Method)
19:46:38         at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
19:46:38         at java.lang.Thread.run(Thread.java:724)
19:46:38 	at __randomizedtesting.SeedInfo.seed([2D997537AD6A02A0:3EAC405B7FBAF091]:0)
{code}

There are two Hadoop task communication threads running. Shouldn't these be destroyed if a
ThreadLeakLingering annotation is added?

> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
>                 Key: MAHOUT-1345
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1345
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Isabel Drost-Fromm
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: MAHOUT-1345.diff, MAHOUT-1345.patch
>
>
> When enabling randomised testing for all modules I found a few tests became unstable
or even fail deterministically due to lingering threads. The attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier as the version
number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads for me on
my machine. I'd greatly appreciate input a) from those who wrote the respective code and b)
others who ran the tests with these changes to make sure there are no other tests that suffer
from the same issues. 
> Warning: I touched quite a few bits and pieces I'm not intimately familiar with over
the last few weeks  (whenever I had a few spare minutes) - second pair of eyes needed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message