mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAHOUT-1303) GenericItemBasedRecommender.estimate(id) method confusing (line 347-349)
Date Thu, 17 Oct 2013 22:33:43 GMT

     [ https://issues.apache.org/jira/browse/MAHOUT-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebastian Schelter updated MAHOUT-1303:
---------------------------------------

    Description: 
--------
 if (excludeItemIfNotSimilarToAll || !Double.isNaN(estimate)) {  -- line 347

          average.addDatum(estimate);

        }

-----

line 347 seems logic confusing, 

if excludeItemIfNotSimilarToAll == true, -> always add data into average, doesn't matter
what the data is , Nan ???


  was:

--------
 if (excludeItemIfNotSimilarToAll || !Double.isNaN(estimate)) {  -- line 347

          average.addDatum(estimate);

        }

-----

line 347 seems logic confusing, 

if excludeItemIfNotSimilarToAll == true, -> always add data into average, doesn't matter
what the data is , Nan ???


       Assignee: Sebastian Schelter

> GenericItemBasedRecommender.estimate(id) method  confusing (line 347-349)
> -------------------------------------------------------------------------
>
>                 Key: MAHOUT-1303
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1303
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering
>    Affects Versions: 0.9
>            Reporter: chsz wu
>            Assignee: Sebastian Schelter
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: MAHOUT-1303.patch
>
>
> --------
>  if (excludeItemIfNotSimilarToAll || !Double.isNaN(estimate)) {  -- line 347
>           average.addDatum(estimate);
>         }
> -----
> line 347 seems logic confusing, 
> if excludeItemIfNotSimilarToAll == true, -> always add data into average, doesn't
matter what the data is , Nan ???



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message