Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mahout.apache.org
Received-SPF: pass (athena.apache.org: domain of ted.dunning@gmail.com
 designates 209.85.219.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <147004206.496006.1375311803417.JavaMail.root@stanford.edu>
References: <20130731225749.2609.72663@reviews.apache.org>
 <147004206.496006.1375311803417.JavaMail.root@stanford.edu>
From: Ted Dunning <ted.dunning@gmail.com>
Date: Wed, 31 Jul 2013 16:45:47 -0700
Message-ID: 
 <CAJwFCa2HptjS_WNMhs50WT7fSMgP_GXX57FgrHsU4ECZGX=GUQ@mail.gmail.com>
Subject: Re: Review Request 13172: #MAHOUT-1273: Single Pass Algorithm for
 Penalized Linear Regression with Cross Validation on MapReduce
To: Mahout Dev List <dev@mahout.apache.org>
Cc: Sebastian Schelter <ssc@apache.org>
Content-Type: multipart/alternative; boundary=001a11c30312f86fc704e2d754d9

--001a11c30312f86fc704e2d754d9
Content-Type: text/plain; charset=UTF-8

Sorry, I just read those documents.  They describe how to solve an
unpenalized problem, not the penalized version.

Those are where I copied that magical step from.


On Wed, Jul 31, 2013 at 4:03 PM, Kun Yang <kunyang@stanford.edu> wrote:

> Thanks for your feedback.
>
> Besides the code, I have also upload the details of the algorithm in the
> project page. Please take a look.
>
> I attached the documents in the email as well.
>
> Best
>
> ----- Original Message -----
> From: "Ted Dunning" <tdunning@apache.org>
> To: "Sebastian Schelter" <ssc@apache.org>, "Ted Dunning" <
> tdunning@apache.org>
> Cc: "Kun Yang" <kunyang@stanford.edu>, "mahout" <dev@mahout.apache.org>
> Sent: Wednesday, July 31, 2013 3:57:49 PM
> Subject: Re: Review Request 13172: #MAHOUT-1273: Single Pass Algorithm for
> Penalized Linear Regression with Cross Validation on MapReduce
>
>
>         This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13172/
> In the paper associated with this code, there is the following magical step
>
>     19: train the model (2) with train data and calculate the mean
>     squared prediction error pi for test data
>
> Until I see a specification of what this algorithm is supposed to be
> doing, I don't see the point in reviewing the code.
>
>
> - Ted Dunning
>
>
> On July 31st, 2013, 10:56 p.m. UTC, Kun Yang wrote:
> Review request for mahout, Sebastian Schelter and Ted Dunning.
> By Kun Yang.
>
> Updated July 31, 2013, 10:56 p.m.
> Repository: mahout-git Description
>         Single-Pass Penalized Linear Regression with Cross Validation on
> MapReduce
>
> For details, please go through the documentation. Testing
>         Units tests for the classes Diffs
>
>
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearConstants.java
> (PRE-CREATION)
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearDriver.java
> (PRE-CREATION)
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearKeySet.java
> (PRE-CREATION)
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearMapper.java
> (PRE-CREATION)
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearReducer.java
> (PRE-CREATION)
>     *
> core/src/main/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearSolver.java
> (PRE-CREATION)
>     *
> core/src/test/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearTest.java
> (PRE-CREATION)
>     *
> examples/src/main/java/org/apache/mahout/regression/penalizedlinear/Job.java
> (PRE-CREATION)
>     *
> examples/src/main/java/org/apache/mahout/regression/penalizedlinear/LinearCrossValidation.java
> (PRE-CREATION)
>     *
> examples/src/main/java/org/apache/mahout/regression/penalizedlinear/LinearRegularizePath.java
> (PRE-CREATION)
>     * examples/src/main/resources/prostate.txt (PRE-CREATION)
>     *
> examples/src/test/java/org/apache/mahout/regression/penalizedlinear/PenalizedLinearExampleTest.java
> (PRE-CREATION)
>     *
> integration/src/main/java/org/apache/mahout/regression/feature/extractor/FeatureExtractUtility.java
> (PRE-CREATION)
>     *
> integration/src/main/java/org/apache/mahout/regression/feature/extractor/FeatureExtractorKeySet.java
> (PRE-CREATION)
>     *
> integration/src/main/java/org/apache/mahout/regression/feature/extractor/FeatureExtractorMapper.java
> (PRE-CREATION)
>     *
> integration/src/test/java/org/apache/mahout/regression/feature/extractor/FeatureExtractorTest.java
> (PRE-CREATION)
>
>
> View Diff

--001a11c30312f86fc704e2d754d9--