Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mahout.apache.org
Received-SPF: pass (nike.apache.org: domain of robin.anil@gmail.com designates
 209.85.128.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAB+3LJncF-GoxehxP=nNzrmp4XwRaYnoHYQJPO+J92q2=v4kCg@mail.gmail.com>
References: 
 <CAOwb3gPVP_+-Fzb9Q_mCDWi3wSc_C2KDTpmfQrBzhePzEwBvjQ@mail.gmail.com>
 <CACYXym-V6hFp9YNVqMtUtVCPOp=Dzi6X7tz_++YefYfnh06LxA@mail.gmail.com>
 <CAJwFCa3gPgjry-83pXGtWzbbC2wN1FasZ0a505gf5AJ2RqjuJg@mail.gmail.com>
 <CAEccTyxbDKEnF-fKVzet3D0=1NhL+Rs=ndLfrA0MiW7DhU0dTA@mail.gmail.com>
 <59E78FFA-AD0E-43A4-915F-6D88BFC069C9@gmail.com>
 <CAB+3LJmdsuUHNBFMtu8iDwT4c5f2d5SvisiCKPafQtNEuCQvCA@mail.gmail.com>
 <CAJwFCa2vd8cDGetU_6TbGpzSGHVpCnhFjU-izguexsndZPR7_g@mail.gmail.com>
 <CAB+3LJnB4EVyALTTi3K5zt6YdL16TVb9869eP=NB_ZEDT=+juA@mail.gmail.com>
 <CAJwFCa3fYCy7XsfqD9u5838Mnonvvhv1Y6ccKXkDZjqGZ_BuxQ@mail.gmail.com>
 <CAB+3LJmUBaJ=-D2SULbhNVRBLWS0YiArd-eajTc3p=-gmOpmqA@mail.gmail.com>
 <CAB+3LJmsomVO7bXCiAqer8rq6cmkKiVHmMBQigEEhi-LVv6M7g@mail.gmail.com>
 <CAJwFCa0eGvKA0+dsR9VMtjuSJp8bdTkCbUYK82k+tDpthGGXTA@mail.gmail.com>
 <CAB+3LJnpNPHRjGZJHrEn5ak33V3F+VN4--c=6a-O44+bg3N5Ug@mail.gmail.com>
 <CAJwFCa1onN7=oFWynKsPtjrnGNQHVWARrfUmEBQjw18=zRXEvw@mail.gmail.com>
 <CAB+3LJ=Ku8rNbM1bOS4Y1oPstvuZ1rg-UcF4SNHsk6ifQcfZeA@mail.gmail.com>
 <CAJwFCa3P5WiRgq3KR-R3P5V+e1f9nQxtOeBORZHU_-QfEbFtgQ@mail.gmail.com>
 <CAB+3LJmM+Q8MQJ_G1WhJj6fx8xasdc-v18xJwRDG_1F3L5-aVw@mail.gmail.com>
 <CAB+3LJkRSL7jEcnRRug4qPLq-XsD=fNwtk2MNf2Xf-m9UVviEA@mail.gmail.com>
 <CAB+3LJncqY7690Uwjkh4_1=_uLj_T561P_Rw_9P8_2Sg7Pvy7w@mail.gmail.com>
 <CAB+3LJncF-GoxehxP=nNzrmp4XwRaYnoHYQJPO+J92q2=v4kCg@mail.gmail.com>
From: Robin Anil <robin.anil@gmail.com>
Date: Sun, 14 Apr 2013 23:34:48 -0500
Message-ID: 
 <CAB+3LJ=8XfYjJwPVqZwb7V+videUKG_uSBUyMog7BNM_kOmnSw@mail.gmail.com>
Subject: Re: Odd vector iteration behavior
To: Mahout-Dev <dev@mahout.apache.org>
Content-Type: multipart/alternative; boundary=bcaec50162e312904804da5ec71e

--bcaec50162e312904804da5ec71e
Content-Type: text/plain; charset=UTF-8

Strike that there are still failures. Investigating. if I cant fix it in
the next hour, I will submit them sometime in the evening tomorrow.

Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc.


On Sun, Apr 14, 2013 at 11:33 PM, Robin Anil <robin.anil@gmail.com> wrote:

> Tests pass. Submitting the patches.
>
> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc.
>
>
> On Sun, Apr 14, 2013 at 11:17 PM, Robin Anil <robin.anil@gmail.com> wrote:
>
>> Added a few more tests. Throw NoSuchElementException like Java
>> Collections when iterating past the end. Things look solid, performance is
>> 2x. All Math tests pass. I am now waiting for the entire test suites to run
>> before submitting.
>>
>> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc.
>>
>>
>> On Sun, Apr 14, 2013 at 9:49 PM, Robin Anil <robin.anil@gmail.com> wrote:
>>
>>> I am not sure what I did. But removing Guava Abstract iterator actually
>>> sped up the dot, cosine, euclidean by another 60%. Things are now 2x faster
>>> than trunk. While also correcting the behavior (I hope)
>>>
>>>
>>> https://docs.google.com/spreadsheet/ccc?key=0AhewTD_ZgznddGFQbWJCQTZXSnFULUYzdURfWDRJQlE#gid=1
>>>
>>> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc.
>>>
>>>
>>> On Sun, Apr 14, 2013 at 8:56 PM, Robin Anil <robin.anil@gmail.com>wrote:
>>>
>>>> Also note that this is code gen, I have to create Element$keyType$Value
>>>> for each and every combination not just int double. and also update all
>>>> callers to user ElementIntDouble instead of Element. Is it worth it ?
>>>>
>>>> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc.
>>>>
>>>>
>>>> On Sun, Apr 14, 2013 at 8:46 PM, Ted Dunning <ted.dunning@gmail.com>wrote:
>>>>
>>>>> Collections (no longer colt collections) are now part of mahout math.
>>>>>  No
>>>>> need to keep them separate.  The lower iterator can reference
>>>>> Vector.Element
>>>>>
>>>>>
>>>>> On Sun, Apr 14, 2013 at 6:24 PM, Robin Anil <robin.anil@gmail.com>
>>>>> wrote:
>>>>>
>>>>> > I would have loved to but Element is a sub interface in Vector. If
>>>>> we want
>>>>> > to keep colt collections separate we have to keep this separation.
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
>

--bcaec50162e312904804da5ec71e--