mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Musselman <andrew.mussel...@gmail.com>
Subject Re: Code reviews and reviewers
Date Tue, 09 Apr 2013 13:16:06 GMT
+1 for code reviews
+1 for Review Board
+1 for unit tests and integration tests


On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon <dangeorge.filimon@gmail.com>wrote:

> Thanks Sebastian!
>
> But let's talk about policy. Wouldn't everyone agree that more code reviews
> are a good thing?
> Ideally, everyone does it and becomes familiar with the code base.
>
> So, even though I, for instance wouldn't be able to say much about
> something I haven't worked on, like recommendation systems, a sanity check
> is always good to have.
> Also good for having a cohesive style and ensuring the code is easy to read
> and is adequately documented.
>
> And, best of all, I get the added bonus of having to read up (at least an
> overview) of how these systems work to provide some more meaningful
> feedback.
>
> Right now, it looks like there aren't that many changes going through
> ReviewBoard. Sure, there's JIRA, but for more significant changes?
>
> Any thoughts on what's best to do?
>
>
>
> On Tue, Apr 9, 2013 at 2:34 PM, Sebastian Schelter
> <ssc.open@googlemail.com>wrote:
>
> > Dan,
> >
> > it's a pleasure to review your code. Ask me anytime :)
> >
> > On 09.04.2013 13:31, Dan Filimon wrote:
> > > Hi everyone,
> > >
> > > Sebastian has been reviewing my code on ReviewBoard [1] for a while now
> > and
> > > I feel bad for always asking him to do it. :)
> > >
> > > Is there anyone else who could have a look (I'll also volunteer when
> you
> > > need a reviewer)?
> > >
> > > [1] https://reviews.apache.org/r/10372/
> > >
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message