mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Dunning <ted.dunn...@gmail.com>
Subject Re: [jira] [Updated] (MAHOUT-1115) [PATCH] Add values() method to FastByIDMap
Date Thu, 15 Nov 2012 17:36:39 GMT
Julien,

At first glance, this looks like a fine addition.  One question I have,
however, is whether you have any test cases for this.

On Thu, Nov 15, 2012 at 8:28 AM, Julien Aymé (JIRA) <jira@apache.org> wrote:

>
>      [
> https://issues.apache.org/jira/browse/MAHOUT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Julien Aymé updated MAHOUT-1115:
> --------------------------------
>
>     Attachment: FastByIDMap.java.patch
>
> The proposed patch
>
> > [PATCH] Add values() method to FastByIDMap
> > ------------------------------------------
> >
> >                 Key: MAHOUT-1115
> >                 URL: https://issues.apache.org/jira/browse/MAHOUT-1115
> >             Project: Mahout
> >          Issue Type: Improvement
> >          Components: collections
> >    Affects Versions: 0.7, 0.8
> >            Reporter: Julien Aymé
> >            Assignee: Benson Margulies
> >            Priority: Trivial
> >              Labels: patch
> >         Attachments: FastByIDMap.java.patch
> >
> >   Original Estimate: 1h
> >  Remaining Estimate: 1h
> >
> > The values() view of FastByIDMap is missing, where as it is implemented
> in FastMap. It should also be provided in FastByIDMap. Patch will follow.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message