mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-1116) WeightedVectors do not implement equals()
Date Fri, 16 Nov 2012 11:06:12 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498727#comment-13498727
] 

Sean Owen commented on MAHOUT-1116:
-----------------------------------

Looking at this again, I think the issue here is that the ordering should not be defined as
a natural ordering via compareTo(), but by a separate Comparator class. Because the class
wholly delegates the idea of equality to the instance it wraps, which have no natural ordering,
it's actually not meaningful to say these have a natural ordering even though they have a
weight field.
                
> WeightedVectors do not implement equals()
> -----------------------------------------
>
>                 Key: MAHOUT-1116
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1116
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 1.0
>            Reporter: Dan Filimon
>            Priority: Minor
>              Labels: newbie
>         Attachments: WeightedVector_MAHOUT_1116.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> WeightedVectors [1] implement compareTo but not equals so in cases where just the weights
or the indices differ, despire compareTo returning 0, equals returns false.
> [1] https://github.com/apache/mahout/blob/trunk/math/src/main/java/org/apache/mahout/math/WeightedVector.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message