mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paritosh Ranjan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MAHOUT-1059) New matrix extensions
Date Mon, 20 Aug 2012 13:50:38 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437861#comment-13437861
] 

Paritosh Ranjan edited comment on MAHOUT-1059 at 8/21/12 12:48 AM:
-------------------------------------------------------------------

I looked at the code. The code is new, and I believe readable unit tests are door to new code.
However, test methods like testUpdate() of CentroidTest having multiple asserts in it does
not give much insight into what update is doing until someone goes through the whole code
and understands it. I also think that the test case for WeightedVector is actually testing
the DelegatingVector.

I did not find any test class for DelegatingVector, which I am attaching. To run this test
case, EasyMock's dependency will be needed in math module.




                
      was (Author: paritoshranjan):
    I looked at the code. The code is new, and I believe readable unit tests are door to new
code. However, test methods like testUpdate() of CentroidTest having multiple asserts in it
does not give much insight into what update is doing until someone goes through the whole
code and understands it. I also think that the test case for WeightedVector is actually testing
the DelegatingVector.

I did not find any test class for DelegatingVector, which I am attaching.




                  
> New matrix extensions
> ---------------------
>
>                 Key: MAHOUT-1059
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1059
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>            Reporter: Ted Dunning
>             Fix For: 0.8
>
>         Attachments: 0001-MAHOUT-1059-Added-Centroid-WeightedVector-Delegating.patch,
0001-MAHOUT-1059-Added-Centroid-WeightedVector-Delegating.patch, 0002-MAHOUT-1059-Stylistic-cleanups.patch,
DelegatingVectorTest.java
>
>
> The upcoming clustering needs several capabilities to support different operations. 
These include some matrix extensions for adding behaviors to different kinds of matrices.
 Also there is a file based matrix that uses mmap to access a file as if it were a matrix
in shared memory.  Since this is off-heap and shared between processes, it can seriously help
some programs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message