mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Hunt <ph...@apache.org>
Subject Re: review board issues
Date Tue, 20 Dec 2011 22:16:48 GMT
Yes, something like that, see this: http://bit.ly/vlY6k8 for some examples.

Patrick

On Mon, Dec 19, 2011 at 6:06 PM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
> Patric,
>
> thank you.
>
> I assume that you want me to ask them to create a configuration for
> git in RB, right? Whatever it means. Then i will be able to submit git
> based diffs, right? Or at least use your scripts with my local git to
> submit those, right?
>
> Sounds like a plan, I will try that.
>
>
>
> On Mon, Dec 19, 2011 at 3:38 PM, Patrick Hunt <phunt@apache.org> wrote:
>> I was only able to get it working with git on zookeeper-git. Even if
>> you get past that issue (accepting the diff) you would see other
>> issues subsequently. iirc SVN RB is pretty finicky about the path for
>> example....
>>
>> I'd suggest you save yourself the hassle, ping infra and have them
>> setup a mahout-git repo.
>>
>> I ended up creating wrapper scripts because it was so onerous:
>> https://github.com/phunt/apache-reviewboard-zk-svn
>> https://github.com/phunt/apache-reviewboard-zk-git
>>
>> (rb-zk-git assumes that you have a <proj>-git RB setup though)
>>
>> Regards,
>>
>> Patrick
>>
>> On Mon, Dec 19, 2011 at 3:18 PM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
>>> i see.
>>> ok i don't want to clone svn repo just to make this working...
>>>
>>> On Mon, Dec 19, 2011 at 2:47 PM, Raphael Cendrillon
>>> <cendrillon1978@gmail.com> wrote:
>>>> Hi Dmitry,
>>>>
>>>> I've been using SVN to generate diffs for reviewboard which work fine.
>>>>
>>>> The diffs coming out of Git seemed to have a different format which I had
problems with, although I didn't spend a lot of time trying to get this working.
>>>>
>>>> On Dec 19, 2011, at 2:01 PM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
>>>>
>>>>> Thanks, Patrick.
>>>>>
>>>>> it says it will accept any unified diff format. Does it mean it will
>>>>> accept a standard 'diff' output?
>>>>>
>>>>> in theory, I can try to tune my local git to produce diffs with a
>>>>> standard diff routine if it works. I
>>>>>
>>>>> am not sure what it has to do with repository type. Other folks in
>>>>> our project seemed to have been able to upload a diff, not sure if
>>>>> they used git diff or something else.
>>>>>
>>>>> Thank you.
>>>>>
>>>>> On Mon, Dec 19, 2011 at 1:49 PM, Patrick Hunt <phunt@apache.org>
wrote:
>>>>>> Hi Dmitriy my experience, at least on ZooKeeper, is that we needed
>>>>>> both a zookeeper and a zookeeper-git repository in order to support
>>>>>> svn & git (respectively) in RB. Try pinging Infra, they can add
this
>>>>>> for you.
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Patrick
>>>>>>
>>>>>> On Mon, Dec 19, 2011 at 12:54 PM, Dmitriy Lyubimov <dlieu.7@gmail.com>
wrote:
>>>>>>> the error i am getting is
>>>>>>>
>>>>>>> No valid separator after the filename was found in the diff header
>>>>>>>
>>>>>>> so it looks like it needs specific tweaks for a patch. However
'patch'
>>>>>>> routine would apply my output cleanly. So i am at loss.
>>>>>>>
>>>>>>> -d
>>>>>>>
>>>>>>> On Mon, Dec 19, 2011 at 12:52 PM, Dmitriy Lyubimov <dlieu.7@gmail.com>
wrote:
>>>>>>>> ok it wouldn't eat up my git diff output no matter what i
do.
>>>>>>>>
>>>>>>>> i tried git diff, git diff -p , git diff -p --no-prefix,
git diff -u
>>>>>>>> --no-prefix for base directories both / and /trunk, all of
these
>>>>>>>> combinations, to no avail. it looks like it doesn't like
git diff
>>>>>>>> output.
>>>>>>>>
>>>>>>>> Any ideas are welcome.

Mime
View raw message