Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mahout.apache.org
Date: Mon, 11 Jul 2011 11:29:59 +0000 (UTC)
From: "Sean Owen (JIRA)" <jira@apache.org>
To: dev@mahout.apache.org
Message-ID: 
 <1137394908.2694.1310383799915.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <80231801.1664.1310336339847.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAHOUT-756) VectorList (Matrix implementation)
 does not maintain cardinality getters correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAHOUT-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063291#comment-13063291 ] 

Sean Owen commented on MAHOUT-756:
----------------------------------

OK, I see: like(int, int) used a DenseVector all the time since it wanted to specify the cardinality concretely. I think it's OK to leave that as-is, as it's not obviously a problem, rather than change its behavior. It's not necessary to make the like() method always use DenseVector though? There it's fine to call Vector.like().

The two methods were not consistent in this regard -- you flipped them both to do what the other did. :) Consistency might be good here... I don't know. Always use DenseVector, or use like() in the one case where you can?

> VectorList (Matrix implementation) does not maintain cardinality getters correctly
> ----------------------------------------------------------------------------------
>
>                 Key: MAHOUT-756
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-756
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>            Reporter: Lance Norskog
>            Priority: Minor
>         Attachments: VectorList.patch
>
>
> VectorList (implements Matrix) is dynamically expandable, row-wise. There are three different ways to query the size of a Matrix, and VectorList does not correctly supply these values.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira