mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Lyubimov <dlie...@gmail.com>
Subject Re: @SuppressWarnings removed
Date Sun, 17 Apr 2011 17:24:41 GMT
should read > In relatively rare cases when warnings are _not_
justified (thus as a lot of



On Sun, Apr 17, 2011 at 10:13 AM, Dmitriy Lyubimov <dlieu.7@gmail.com> wrote:
> Sean,
> I noticed you removed @SuppressWarnings annotations.
>
> As a result, there's a bunch of warnings in the SSVD code.
> I normally check all warnings and _usually_ warnings are justified and
> helpful to find bugs proactively.
>
> In relatively rare cases when warnings are justified (thus as a lot of
> instances in hadoop when their styling forces generics warnings, i
> reset them with @SuppressWarnings to signal they are validated to be
> o.k. in this cases.
>
> But if you remove those, this is quite unfortunate. This masks real
> warnings that need to be checked or forces me to do scan for warnings
> where i already did that.
>
> What gives?
>

Mime
View raw message