mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAHOUT-633) Add SequenceFileIterable; put Iterable stuff in one place
Date Tue, 29 Mar 2011 19:32:05 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012639#comment-13012639
] 

Sean Owen commented on MAHOUT-633:
----------------------------------

Sounds like we just need a new flag or something to select reuse of the key/value objects.
Then I can go back and enable it where the code seemed to have been reusing them already.
I can get on that along with ordering support.

While it's sounding complex... I think it's really not much, compared to the amount of clean-up
and code removal this is enabling. I quite like all this.

Good luck reading the patch. Really, you want to look at new code in .common.iterator.sequencefile,
and how it's used in your bits of code. The rest is probably not relevant.

> Add SequenceFileIterable; put Iterable stuff in one place
> ---------------------------------------------------------
>
>                 Key: MAHOUT-633
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-633
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification, Clustering, Collaborative Filtering
>    Affects Versions: 0.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: iterable, iterator, sequence-file
>             Fix For: 0.5
>
>         Attachments: MAHOUT-633.patch, MAHOUT-633.patch, MAHOUT-633.patch
>
>
> In another project I have a useful little class, SequenceFileIterable, which simplifies
iterating over a sequence file. It's like FileLineIterable. I'd like to add it, then use it
throughout the code. See patch, which for now merely has the proposed new classes. 
> Well it also moves some other iterator-related classes that seemed to be outside their
rightful home in common.iterator.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message