Mailing-List: contact dev-help@mahout.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mahout.apache.org
Message-ID: <23892853.284061296279883346.JavaMail.jira@thor>
Date: Sat, 29 Jan 2011 00:44:43 -0500 (EST)
From: "Lance Norskog (JIRA)" <jira@apache.org>
To: dev@mahout.apache.org
Subject: [jira] Updated: (MAHOUT-599) AbstractMatrix uses clone() where it
 should use like()
In-Reply-To: <5195632.284021296279763566.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAHOUT-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated MAHOUT-599:
---------------------------------

    Attachment: MAHOUT-599.patch

> AbstractMatrix uses clone() where it should use like()
> ------------------------------------------------------
>
>                 Key: MAHOUT-599
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-599
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: MAHOUT-599.patch
>
>
> The AbstractMatrix.java class uses clone() instead of like() in the methods which create a new matrix and populate it with calculated data. This means that the contents of 'this' is copied into the return matrix, then promptly overwritten.
> This patch fixes this problem by substituting like() and changing the code to not rely on having the values of 'this' in the clone.
> Also, this allows generated matrices like a random matrix to reuse the code from AbstractMatrix; read-only matrices cannot populate their clones.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.