mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lance Norskog (JIRA)" <>
Subject [jira] Updated: (MAHOUT-599) AbstractMatrix uses clone() where it should use like()
Date Sat, 29 Jan 2011 05:44:43 GMT


Lance Norskog updated MAHOUT-599:

    Attachment: MAHOUT-599.patch

> AbstractMatrix uses clone() where it should use like()
> ------------------------------------------------------
>                 Key: MAHOUT-599
>                 URL:
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 0.5
>         Attachments: MAHOUT-599.patch
> The class uses clone() instead of like() in the methods which create
a new matrix and populate it with calculated data. This means that the contents of 'this'
is copied into the return matrix, then promptly overwritten.
> This patch fixes this problem by substituting like() and changing the code to not rely
on having the values of 'this' in the clone.
> Also, this allows generated matrices like a random matrix to reuse the code from AbstractMatrix;
read-only matrices cannot populate their clones.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message