mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAHOUT-404) AbstractJob improvements.
Date Mon, 07 Jun 2010 12:18:40 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876222#action_12876222
] 

Sean Owen commented on MAHOUT-404:
----------------------------------

Looks OK to me. As far as I'm concerned, go ahead and let me play with the result.

> AbstractJob improvements.
> -------------------------
>
>                 Key: MAHOUT-404
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-404
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Utils
>    Affects Versions: 0.4
>            Reporter: Drew Farris
>         Attachments: MAHOUT-404.patch, MAHOUT-404.patch
>
>
> Per discussion : http://lucene.472066.n3.nabble.com/Re-input-now-Dmapred-input-dir-td852297.html#a852297
> With the advent of the parsedArgs map returned by AbstractJob.parseArguments is there
> a need to pass Option arguments around anymore? Could AbstractJob maintain
> Options state in a sense?
> For example, from RecommenderJob:
> {code}
>     Option numReccomendationsOpt = AbstractJob.buildOption("numRecommendations", "n",

>       "Number of recommendations per user", "10");
>     Option usersFileOpt = AbstractJob.buildOption("usersFile", "u",
>       "File of users to recommend for", null);
>     Option booleanDataOpt = AbstractJob.buildOption("booleanData", "b",
>       "Treat input as without pref values", Boolean.FALSE.toString());
>     Map<String,String> parsedArgs = AbstractJob.parseArguments(
>         args, numReccomendationsOpt, usersFileOpt, booleanDataOpt);
>     if (parsedArgs == null) {
>       return -1;
>     }
> {code}
> Could be changed to something like:
> {code}
> buildOption("numRecommendations", "n", "Number of recommendations per user",
> "10");
> buildOption("usersFile", "u", "File of users to recommend for", null);
> buildOption("booleanData", "b", "Treat input as without pref values",
> Boolean.FALSE.toString());
> Map<String,String> parsedArgs = parseArguments(); 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message