mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robin Anil (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAHOUT-301) Improve command-line shell script by allowing default properties files
Date Fri, 26 Feb 2010 04:22:27 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838700#action_12838700
] 

Robin Anil commented on MAHOUT-301:
-----------------------------------

+1 for committing this. 

Can you upload the patch for the maven configs. Maybe a separate issue? and mark it as 0.3.


> Improve command-line shell script by allowing default properties files
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-301
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-301
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Utils
>    Affects Versions: 0.3
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: MAHOUT-301-drew.patch, MAHOUT-301-drew.patch, MAHOUT-301.patch,
MAHOUT-301.patch, MAHOUT-301.patch, MAHOUT-301.patch, MAHOUT-301.patch, MAHOUT-301.patch
>
>
> Snippet from javadoc gives the idea:
> {code}
> /**
>  * General-purpose driver class for Mahout programs.  Utilizes org.apache.hadoop.util.ProgramDriver
to run
>  * main methods of other classes, but first loads up default properties from a properties
file.
>  *
>  * Usage: run on Hadoop like so:
>  *
>  * $HADOOP_HOME/bin/hadoop -jar path/to/job org.apache.mahout.driver.MahoutDriver [classes.props
file] shortJobName \
>  *   [default.props file for this class] [over-ride options, all specified in long form:
--input, --jarFile, etc]
>  *
>  * TODO: set the Main-Class to just be MahoutDriver, so that this option isn't needed?
>  *
>  * (note: using the current shell scipt, this could be modified to be just 
>  * $MAHOUT_HOME/bin/mahout [classes.props file] shortJobName [default.props file] [over-ride
options]
>  * )
>  *
>  * Works like this: by default, the file "core/src/main/resources/driver.classes.prop"
is loaded, which
>  * defines a mapping between short names like "VectorDumper" and fully qualified class
names.  This file may
>  * instead be overridden on the command line by having the first argument be some string
of the form *classes.props.
>  *
>  * The next argument to the Driver is supposed to be the short name of the class to be
run (as defined in the
>  * driver.classes.props file).  After this, if the next argument ends in ".props" / ".properties",
it is taken to
>  * be the file to use as the default properties file for this execution, and key-value
pairs are built up from that:
>  * if the file contains
>  *
>  * input=/path/to/my/input
>  * output=/path/to/my/output
>  *
>  * Then the class which will be run will have it's main called with
>  *
>  *   main(new String[] { "--input", "/path/to/my/input", "--output", "/path/to/my/output"
});
>  *
>  * After all the "default" properties are loaded from the file, any further command-line
arguments are taken in,
>  * and over-ride the defaults.
>  */
> {code}
> Could be cleaned up, as it's kinda ugly with the whole "file named in .props", but gives
the idea.  Really helps cut down on repetitive long command lines, lets defaults be put props
files instead of locked into the code also.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message